Skip to content

Commit

Permalink
dev
Browse files Browse the repository at this point in the history 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
@tchughesiv
tchughesiv committed Oct 30, 2024
1 parent 85e6765 commit 0571364
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 36 deletions.
4 changes: 2 additions & 2 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ type LocalRegistryConfig struct {
ServiceConfigs `json:",inline"`
}

// Registry ... One selection, local or remote, is required. Local is the default setting.
// Registry configures the registry service. One selection is required. Local is the default setting.
// +kubebuilder:validation:XValidation:rule="[has(self.local), has(self.remote)].exists_one(c, c)",message="One selection required."
type Registry struct {
Local *LocalRegistryConfig `json:"local,omitempty"`
Remote *RemoteRegistryConfig `json:"remote,omitempty"`
}

// RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
// Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection, hostname or feastRef, is required.
// Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
// +kubebuilder:validation:XValidation:rule="[has(self.hostname), has(self.feastRef)].exists_one(c, c)",message="One selection required."
type RemoteRegistryConfig struct {
// Service host address - <domain>:<port>, e.g. `registry.namespace.svc.cluster.local:80`
Expand Down
2 changes: 1 addition & 1 deletion infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2024-10-29T12:03:32Z"
createdAt: "2024-10-30T20:49:07Z"
operators.operatorframework.io/builder: operator-sdk-v1.37.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.41.0
Expand Down
57 changes: 36 additions & 21 deletions infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ spec:
ephemeral registry is deployed by default.
properties:
offlineStore:
description: OfflineStore
description: OfflineStore configures the deployed offline store
service
properties:
image:
type: string
Expand Down Expand Up @@ -125,7 +126,8 @@ spec:
type: object
type: object
onlineStore:
description: OnlineStore
description: OnlineStore configures the deployed online store
service
properties:
image:
type: string
Expand Down Expand Up @@ -191,10 +193,12 @@ spec:
type: object
type: object
registry:
description: Registry
description: Registry configures the registry service. One selection
is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig
description: LocalRegistryConfig configures the deployed registry
service
properties:
image:
type: string
Expand Down Expand Up @@ -261,11 +265,13 @@ spec:
type: object
type: object
remote:
description: RemoteRegistryConfig
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: FeatureStoreRef defines which existing FeatureStore's
registry should be used
description: Reference to an existing `FeatureStore` CR
in the same k8s cluster.
properties:
name:
description: Name of the FeatureStore
Expand All @@ -276,13 +282,14 @@ spec:
required:
- name
type: object
url:
description: ?? ServiceHostname *string `json:"serviceHostname,omitempty"`
hostname:
description: Service host address - <domain>:<port>, e.g.
`registry.namespace.svc.cluster.local:80`
type: string
type: object
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.url), has(self.feastRef)].exists_one(c,
rule: '[has(self.hostname), has(self.feastRef)].exists_one(c,
c)'
type: object
x-kubernetes-validations:
Expand All @@ -309,7 +316,8 @@ spec:
ephemeral registry is deployed by default.
properties:
offlineStore:
description: OfflineStore
description: OfflineStore configures the deployed offline
store service
properties:
image:
type: string
Expand Down Expand Up @@ -376,7 +384,8 @@ spec:
type: object
type: object
onlineStore:
description: OnlineStore
description: OnlineStore configures the deployed online store
service
properties:
image:
type: string
Expand Down Expand Up @@ -443,10 +452,12 @@ spec:
type: object
type: object
registry:
description: Registry
description: Registry configures the registry service. One
selection is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig
description: LocalRegistryConfig configures the deployed
registry service
properties:
image:
type: string
Expand Down Expand Up @@ -513,11 +524,13 @@ spec:
type: object
type: object
remote:
description: RemoteRegistryConfig
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: FeatureStoreRef defines which existing
FeatureStore's registry should be used
description: Reference to an existing `FeatureStore`
CR in the same k8s cluster.
properties:
name:
description: Name of the FeatureStore
Expand All @@ -528,13 +541,14 @@ spec:
required:
- name
type: object
url:
description: ?? ServiceHostname *string `json:"serviceHostname,omitempty"`
hostname:
description: Service host address - <domain>:<port>,
e.g. `registry.namespace.svc.cluster.local:80`
type: string
type: object
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.url), has(self.feastRef)].exists_one(c,
rule: '[has(self.hostname), has(self.feastRef)].exists_one(c,
c)'
type: object
x-kubernetes-validations:
Expand Down Expand Up @@ -621,7 +635,8 @@ spec:
phase:
type: string
serviceHostnames:
description: ServiceHostnames
description: ServiceHostnames defines the service hostnames in the
format of <domain>:<port>, e.g. example.svc.cluster.local:80
properties:
offlineStore:
type: string
Expand Down
12 changes: 6 additions & 6 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ spec:
type: object
type: object
registry:
description: Registry ... One selection, local or remote, is required.
Local is the default setting.
description: Registry configures the registry service. One selection
is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig configures the deployed registry
Expand Down Expand Up @@ -267,7 +267,7 @@ spec:
remote:
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection, hostname or feastRef, is required.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: Reference to an existing `FeatureStore` CR
Expand Down Expand Up @@ -452,8 +452,8 @@ spec:
type: object
type: object
registry:
description: Registry ... One selection, local or remote,
is required. Local is the default setting.
description: Registry configures the registry service. One
selection is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig configures the deployed
Expand Down Expand Up @@ -526,7 +526,7 @@ spec:
remote:
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection, hostname or feastRef, is required.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: Reference to an existing `FeatureStore`
Expand Down
12 changes: 6 additions & 6 deletions infra/feast-operator/dist/install.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ spec:
type: object
type: object
registry:
description: Registry ... One selection, local or remote, is required.
Local is the default setting.
description: Registry configures the registry service. One selection
is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig configures the deployed registry
Expand Down Expand Up @@ -275,7 +275,7 @@ spec:
remote:
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection, hostname or feastRef, is required.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: Reference to an existing `FeatureStore` CR
Expand Down Expand Up @@ -460,8 +460,8 @@ spec:
type: object
type: object
registry:
description: Registry ... One selection, local or remote,
is required. Local is the default setting.
description: Registry configures the registry service. One
selection is required. Local is the default setting.
properties:
local:
description: LocalRegistryConfig configures the deployed
Expand Down Expand Up @@ -534,7 +534,7 @@ spec:
remote:
description: |-
RemoteRegistryConfig points to a remote feast registry server. When set, the operator will not deploy a registry for this FeatureStore CR.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection, hostname or feastRef, is required.
Instead, this FeatureStore CR's online/offline services will use a remote registry. One selection is required.
properties:
feastRef:
description: Reference to an existing `FeatureStore`
Expand Down

0 comments on commit 0571364

Please sign in to comment.