V14 (#216)

* remove unnecessary override * ecmaVersion 2020 * add no-promise-executor-return * no-unreachable-loop * v14
tclindner · Aug 30, 2020 · a9898c1 · a9898c1
1 parent 4e44a56
commit a9898c1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/.npmpackagejsonlintrc.json b/.npmpackagejsonlintrc.json
@@ -1,6 +1,3 @@
 {
-  "extends": "npm-package-json-lint-config-tc",
-  "rules": {
-    "valid-values-engines": "off"
-  }
+  "extends": "npm-package-json-lint-config-tc"
 }
diff --git a/index.js b/index.js
@@ -22,7 +22,7 @@ module.exports = {
   ],
   plugins: ['jest', 'prettier'],
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 2020,
     sourceType: 'module',
   },
   env: {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-tc",
-  "version": "13.0.2",
+  "version": "14.0.0",
   "description": "ESLint shareable config for JavaScript projects",
   "keywords": [
     "eslintconfig",

diff --git a/rules/best-practices.js b/rules/best-practices.js
@@ -11,9 +11,11 @@ module.exports = {
     'no-implicit-globals': 'error',
     'no-labels': 'error',
     'no-param-reassign': 'error',
+    'no-promise-executor-return': 'error',
     'no-unmodified-loop-condition': 'error',
     'no-unused-expressions': 'error',
     'no-useless-call': 'error',
+    'no-unreachable-loop': 'error',
     'no-warning-comments': 'warn',
     'require-await': 'error',
   },