Remove overrides #184
Merged
Remove overrides #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tclindner
approved these changes
Jun 14, 2020
tclindner
reviewed
Jun 14, 2020
| @@ -82,14 +82,6 @@ module.exports = { | |||
| 'jest/valid-expect': 'error', | |||
| 'jest/valid-title': 'error', | |||
| 'max-lines': 'off', | |||
| 'max-lines-per-function': 'off', | |||
There was a problem hiding this comment.
On second thought, we might want to add max-lines-per-function, max-statements, max-nested-callbacks, and no-undefined back in. It is useful in tests to check if something is undefined. It is also useful to nest describe and test blocks. What do you think?
There was a problem hiding this comment.
I agree they are useful but they are already set in files in the rules folder which I think covers us - right?
There was a problem hiding this comment.
This section is the overrides section for test files only. If we want the rule disabled for tests we will need to add it here.
There was a problem hiding this comment.
Ahh I missed that. And that makes sense to add back in sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some overrides.
These are actually duplicated in this repository so removed them from the index file:
This has been deprecated in favor of
padding-line-between-statements:This has also been totally deprecated: