Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: no duplicate fields #180

Merged
merged 1 commit into from
Dec 15, 2019
Merged

New rule: no duplicate fields #180

merged 1 commit into from
Dec 15, 2019

Conversation

effrenus
Copy link
Contributor

@effrenus effrenus commented Dec 9, 2019

Disallow duplicate properties in package.json. Realted to #171.

Detection algorithm:

  • Save source json string.
  • Parse source via jsonc-parser.
  • Traverse parse tree and collect duplicates.

Checklist

  • Unit tests have been added
  • Specific notes for documentation, if applicable

@effrenus effrenus requested a review from tclindner as a code owner December 9, 2019 18:46
@effrenus
Copy link
Contributor Author

@tclindner Could you check this PR? Thanks.

@tclindner
Copy link
Owner

Nice work, @effrenus! 🎉 Thank you for contributing. I'll get a release cut today.

@tclindner tclindner merged commit 12470e8 into tclindner:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclindner tclindner Awaiting requested review from tclindner tclindner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effrenus @tclindner