Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esbuild from 0.14.31 to 0.14.32 #642

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 6, 2022

Bumps esbuild from 0.14.31 to 0.14.32.

Release notes

Sourced from esbuild's releases.

v0.14.32

  • Fix super usage in lowered private methods (#2039)

    Previously esbuild failed to transform super property accesses inside private methods in the case when private methods have to be lowered because the target environment doesn't support them. The generated code still contained the super keyword even though the method was moved outside of the class body, which is a syntax error in JavaScript. This release fixes this transformation issue and now produces valid code:

    // Original code
    class Derived extends Base {
      #foo() { super.foo() }
      bar() { this.#foo() }
    }
    // Old output (with --target=es6)
    var _foo, foo_fn;
    class Derived extends Base {
    constructor() {
    super(...arguments);
    __privateAdd(this, _foo);
    }
    bar() {
    __privateMethod(this, _foo, foo_fn).call(this);
    }
    }
    _foo = new WeakSet();
    foo_fn = function() {
    super.foo();
    };
    // New output (with --target=es6)
    var _foo, foo_fn;
    const _Derived = class extends Base {
    constructor() {
    super(...arguments);
    __privateAdd(this, _foo);
    }
    bar() {
    __privateMethod(this, _foo, foo_fn).call(this);
    }
    };
    let Derived = _Derived;
    _foo = new WeakSet();
    foo_fn = function() {
    __superGet(_Derived.prototype, this, "foo").call(this);
    };

    Because of this change, lowered super property accesses on instances were rewritten so that they can exist outside of the class body. This rewrite affects code generation for all super property accesses on instances including those inside lowered async functions. The new approach is different but should be equivalent to the old approach:

    // Original code

... (truncated)

Changelog

Sourced from esbuild's changelog.

0.14.32

  • Fix super usage in lowered private methods (#2039)

    Previously esbuild failed to transform super property accesses inside private methods in the case when private methods have to be lowered because the target environment doesn't support them. The generated code still contained the super keyword even though the method was moved outside of the class body, which is a syntax error in JavaScript. This release fixes this transformation issue and now produces valid code:

    // Original code
    class Derived extends Base {
      #foo() { super.foo() }
      bar() { this.#foo() }
    }
    // Old output (with --target=es6)
    var _foo, foo_fn;
    class Derived extends Base {
    constructor() {
    super(...arguments);
    __privateAdd(this, _foo);
    }
    bar() {
    __privateMethod(this, _foo, foo_fn).call(this);
    }
    }
    _foo = new WeakSet();
    foo_fn = function() {
    super.foo();
    };
    // New output (with --target=es6)
    var _foo, foo_fn;
    const _Derived = class extends Base {
    constructor() {
    super(...arguments);
    __privateAdd(this, _foo);
    }
    bar() {
    __privateMethod(this, _foo, foo_fn).call(this);
    }
    };
    let Derived = _Derived;
    _foo = new WeakSet();
    foo_fn = function() {
    __superGet(_Derived.prototype, this, "foo").call(this);
    };

    Because of this change, lowered super property accesses on instances were rewritten so that they can exist outside of the class body. This rewrite affects code generation for all super property accesses on instances including those inside lowered async functions. The new approach is different but should be equivalent to the old approach:

... (truncated)

Commits
  • 5829301 publish 0.14.32 to npm
  • 44d70d3 add wasmModule option to initialize JS API (#2155)
  • e86abce mark symbol static properties as side-effect free
  • 516796f fix tree-shaking regarding property side effects
  • 457cf22 Update CHANGELOG.md
  • 0a7ac6f fix #2039: lower super in private methods
  • 7f87558 super property shim: change to work outside class
  • e24dfc7 better errors in end-to-end keep name tests
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.14.31 to 0.14.32.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.14.31...v0.14.32)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from tclindner as a code owner April 6, 2022 23:01
@dependabot dependabot bot added the dependencies 📦 Pull requests that update a dependency file label Apr 6, 2022
@tclindner tclindner enabled auto-merge (squash) April 7, 2022 02:17
@tclindner tclindner merged commit 439dfac into master Apr 7, 2022
@tclindner tclindner deleted the dependabot/npm_and_yarn/esbuild-0.14.32 branch April 7, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant