Added version flag #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually won't work, going to fix it. |
coltonmorris
commented
Jan 22, 2022
| go_binary( | ||
| name = "wollemi", | ||
| srcs = ["main.go"], | ||
| visibility = ["PUBLIC"], | ||
| definitions = { | ||
| "github.com/tcncloud/wollemi/ports/wollemi.WollemiVersion": VERSION, |
There was a problem hiding this comment.
We could also just avoid the genrule and build_defs and just hard code the version here ?
| @@ -1,7 +1,12 @@ | |||
| subinclude("//build_defs:version") | |||
There was a problem hiding this comment.
Keeping the VERSION file in the root of the repo and defining a filegroup for it causes a circular dependency because //build_defs:version requires that filegroup, and the go_binary requires //build_defs:version.
I see two possibilities:
- move the wollemi binary up a directory.
- This would allow the VERSION file to remain in the root of the repo, which is where most people would expect it.
- not likely to be forgotten about.
- avoid all the genrule and build_def steps and hard code the version in the go_binary definitions attribute.
- no major changes needed for this
- could be easy to forget about this and forget to increment the version on a new release
- less clear where to increment the version for new contributors
| @@ -0,0 +1 @@ | |||
| 0.7.2 | |||
There was a problem hiding this comment.
Ideally we would have this VERSION file in the root of the repo, but a circular dependency is formed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
latestas the version for local and non tagged builds.