Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Based on Status Response #94

Closed
ThunderSon opened this issue May 23, 2020 · 3 comments · Fixed by #106
Closed

Filter Based on Status Response #94

ThunderSon opened this issue May 23, 2020 · 3 comments · Fixed by #106

Comments

@ThunderSon
Copy link
Contributor

Hello!
Is there a possibility to add the option to filter based on the response status? In some projects, I receive a status of 0, or 403, while they are functioning normally (So mainly related to how they're being responsive to the tool).

Let me know if I can help as well.

@koppor
Copy link
Contributor

koppor commented May 27, 2020

http 403 is forbidden. Maybe, that URLs should be included as URL pattern?

In my case, I would like to filter out HTTP 429 Too Many Requests. This happens when I'm checking links to github.com repositories using github workflows

grafik

@bflad
Copy link

bflad commented Jun 7, 2020

We have the same exact use case and issue as @koppor with a GitHub Actions workflow checking links against github.com, where it can occasionally return a 429 status code for random links. In our case we would be okay to ignore those although ideally it would retry.

Example GitHub Actions run: https://github.com/terraform-providers/terraform-provider-aws/pull/13655/checks?check_run_id=747512585

FILE: docs/MAINTAINING.md
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/provider → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/question → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/regression → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/reinvent → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/stale → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/technical-debt → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/tests → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/thinking → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/upstream-terraform → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/upstream → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/waiting-response → Status: 429

85 links checked.

ERROR: 11 dead links found!
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/provider → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/question → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/regression → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/reinvent → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/stale → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/technical-debt → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/tests → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/thinking → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/upstream-terraform → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/upstream → Status: 429
[✖] https://github.com/terraform-providers/terraform-provider-aws/labels/waiting-response → Status: 429

@NicolasMassart
Copy link
Contributor

I pushed a PR for this http 429 issue #106
Hopefully it will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants