Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown-link-check #6542

Merged
merged 17 commits into from
Jun 16, 2020
Merged

Add markdown-link-check #6542

merged 17 commits into from
Jun 16, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented May 27, 2020

Follow up from #6524

Because GitHub often replies with 429, checking of github.com URLs is excluded. Filter by status will be done in future work. See tcort/markdown-link-check#94 (comment).

The link checker is called AFTER the linter, because this check depends on external hosts - and we should first check the independent things.

@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label May 28, 2020
@Siedlerchr
Copy link
Member

I close this PR for the moment to clear up our PR list. Feel free to reopen the PR when the external dependecncy is resolved

@Siedlerchr Siedlerchr closed this Jun 13, 2020
@koppor koppor removed the status: depends-on-external A bug or issue that depends on an update of an external library label Jun 14, 2020
@koppor koppor reopened this Jun 14, 2020
@koppor
Copy link
Member Author

koppor commented Jun 14, 2020

Thank you for reminding me that upstream fixed the issue and that I just have to rerun the check to check if its working (and then probably fix some broken external links).

@koppor koppor marked this pull request as ready for review June 16, 2020 22:26
@koppor koppor merged commit bc63ccb into master Jun 16, 2020
@koppor koppor deleted the add-link-check branch June 16, 2020 22:26
Siedlerchr added a commit that referenced this pull request Jun 20, 2020
* upstream/master:
  Validates the file path of a TexGroup and fixes Texgroup's "Library has been modified by another program" (#6586)
  Bump postgresql from 42.2.12 to 42.2.14 (#6610)
  Add markdown-link-check (#6542)
  Catch InaccessibleObjectException (#6519)
  Fix author formatter for unchanged names (#6552)
  Bump com.simonharrer.modernizer from 1.8.0-1 to 2.1.0-1
  Bump org.beryx.jlink from 2.19.0 to 2.20.0
  Bump classgraph from 4.8.83 to 4.8.86
  Update FileUtilTest.java
  Update FileUtilTest.java
  Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635
  Update FileUtilTest.java
  Update MoveFilesCleanupTest.java
  checkstyle
  Fix dowmloaded files moved to citaiton key dir
koppor pushed a commit that referenced this pull request Jun 1, 2023
6b7fdff8cb Create journal-of-the-american-philosophical-association.csl (#6542)
9bae9efc55 Update german-council-of-economic-experts.csl (#6562)
256250be9c Update springer-vancouver-brackets.csl (#6546)
f422ca9c9a Update turabian-fullnote-bibliography.csl (#6540)
2833b5d5d5 Update mots.csl (#6556)
44758704b0 Update and rename harvard-the-university-of-melbourne.csl to dependen… (#6547)
08e65fc8e1 Update ieee-with-url.csl (#6514)
06e98f4387 Fix erroneous comma in ACL in-text citation (#6553)
72e16a19cd Update bibliothek-forschung-und-praxis.csl (#6527)
50bae82394 Create Food and Agriculture Organization of the United Nations (numeric) (#6544)
234a3c35d8 Update bern-university-of-applied-sciences-school-of-agricultural-for… (#6552)
3e9e2d6e93 Fix et al and name settings in universitat bern institut fur sozialanthropologie (#6554)
e8e06888fe Update harvard-university-of-the-west-of-england.csl (#6520)
dbbe5c1a95 Update united-states-international-trade-commission.csl (#6535)
b985431f03 Update american-society-for-horticultural-science.csl (#6543)
e1ff9f5546 Sort APA and derivatives on displayed date, not full date (#6545)
7302832d6d Localize original-work-published in APA (#6388)
77a61c0d82 Update united-states-international-trade-commission.csl (#6526)
541807a057 Update the-accounting-review.csl (#6521)
708626357a  Update united-states-international-trade-commission

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 6b7fdff8cb0fb45b342e8ac319634bf18168c73d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants