Optimize initializer #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldiscala
force-pushed
the
optimize-initializer
branch
from
1690460 to
5b60000
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 98.79% 96.42% -2.37%
==========================================
Files 1 1
Lines 83 84 +1
==========================================
- Hits 82 81 -1
- Misses 1 3 +2
Continue to review full report at Codecov.
|
|
👍 from me. @tcrayford can you take a look please? |
tcrayford
reviewed
Mar 22, 2017
| "@#{fields[idx]} = values[#{idx}]" | ||
| end.join("\n") | ||
|
|
||
| class_eval <<-RUBY |
There was a problem hiding this comment.
this looks great, thanks! Mind adding a comment here mentioning this optimization? Whilst this library doesn't change much, I like to prevent opportunities for bitrot where possible.
There was a problem hiding this comment.
Thanks for the review -- I added a comment above this section to explain a bit more of what's happening and to point back to the PR. Does that cover what you were hoping for?
ms-ati
added a commit
to ms-ati/Values
that referenced
this pull request
Mar 22, 2017
This PR is inspired by tcrayford#56, and assumes that code will be merged, so uses it in the benchmarks here: https://gist.github.com/ms-ati/fa8002ef8a0ce00716e9aa6510d3d4d9 It is common in our code, as in any idiomatic code using value objects in loops or pipelines, to call `#with` many times, returning a new immutable object each time with 1 or more fields replaced with new values. The optimizations in this PR eliminate a number of extra Hash and Array instantiations that were occurring each time, in favor of iterating only over the constant `VALUE_ATTRS` array and doing key lookups in the given Hash parameter in the hot paths. Per the gist above, this increases ips (iterations per second) 2.29x, from 335.9 to 769.6 on my machine.
|
nice, thanks! I'll cut a new release over the weekend if I get time. |
ms-ati
added a commit
to ms-ati/Values
that referenced
this pull request
Mar 23, 2017
This PR is inspired by tcrayford#56, and assumes that code will be merged, so uses it in the benchmarks here: https://gist.github.com/ms-ati/fa8002ef8a0ce00716e9aa6510d3d4d9 It is common in our code, as in any idiomatic code using value objects in loops or pipelines, to call `#with` many times, returning a new immutable object each time with 1 or more fields replaced with new values. The optimizations in this PR eliminate a number of extra Hash and Array instantiations that were occurring each time, in favor of iterating only over the constant `VALUE_ATTRS` array and doing key lookups in the given Hash parameter in the hot paths. Per the gist above, this increases ips (iterations per second) 2.29x, from 335.9 to 769.6 on my machine.
tomeon
pushed a commit
to ruby-clubhouse/Values
that referenced
this pull request
Apr 21, 2024
This PR is inspired by tcrayford#56, and assumes that code will be merged, so uses it in the benchmarks here: https://gist.github.com/ms-ati/fa8002ef8a0ce00716e9aa6510d3d4d9 It is common in our code, as in any idiomatic code using value objects in loops or pipelines, to call `#with` many times, returning a new immutable object each time with 1 or more fields replaced with new values. The optimizations in this PR eliminate a number of extra Hash and Array instantiations that were occurring each time, in favor of iterating only over the constant `VALUE_ATTRS` array and doing key lookups in the given Hash parameter in the hot paths. Per the gist above, this increases ips (iterations per second) 2.29x, from 335.9 to 769.6 on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the Values gem extensively in our application and in some pipelines allocate hundreds of thousands of these objects. As a result we're particularly sensitive to the performance of the
#initializemethod.By switching from
define_methodto aclass_eval, we roughly 2x the number of allocations that can be performed in a given timespan:value is the original implementaion and value2 is the code provided in this patch. See https://gist.github.com/michaeldiscala/cee9dbefa06e0d73e15d5bb095ba11bd for the benchmark script.