HTML: don't keep whitespace after closing block tags with KeepWhitesp…

…ace, fixes #442
tdewolff · Sep 21, 2021 · 1328bfb · 1328bfb
1 parent 8a4a1bb
commit 1328bfb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/html/html.go b/html/html.go
@@ -274,10 +274,10 @@ func (o *Minifier) Minify(m *minify.M, w io.Writer, r io.Reader, _ map[string]st
 					}
 				}
 
-				if o.KeepWhitespace || t.Traits&objectTag != 0 {
-					omitSpace = false
-				} else if t.Traits&nonPhrasingTag != 0 {
+				if t.Traits&nonPhrasingTag != 0 {
 					omitSpace = true // omit spaces after block elements
+				} else if o.KeepWhitespace || t.Traits&objectTag != 0 {
+					omitSpace = false
 				}
 
 				if !omitEndTag {

diff --git a/html/html_test.go b/html/html_test.go
@@ -279,6 +279,7 @@ func TestHTMLKeepWhitespace(t *testing.T) {
 		{"abc\n</body>\ndef", "abc\ndef"},
 		{"<x>\n<!--y-->\n</x>", "<x>\n</x>"},
 		{"<style>lala{color:red}</style>", "<style>lala{color:red}</style>"},
+		{"<li>one\n</li>\n<li>two", "<li>one\n<li>two"}, // #442
 	}
 
 	m := minify.New()