test(bindings/js): unfix segfault

tdewolff · Jul 10, 2022 · 1fbad93 · 1fbad93
1 parent c7c19e3
commit 1fbad93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/bindings/js/minify.go b/bindings/js/minify.go
@@ -166,7 +166,9 @@ func minifyFile(cmediatype, cinput, coutput *C.char) *C.char {
 
 //export minifyCleanup
 func minifyCleanup() {
-	os.Exit(0)
+	// This will fix the worker thread segfault test by explicitly ending the node
+	// process with a 0 signal
+	// os.Exit(0)
 }
 
 func main() {}
diff --git a/bindings/js/test/worker.js b/bindings/js/test/worker.js
@@ -19,6 +19,7 @@ if (isMainThread) {
         throw "unexpected output using worker threads: '"+output+"' instead of '"+expected+"'";
     }
     await worker.terminate();
+    console.log("success!"); // this needs to be printed
 } else {
     const { config, string } = await import('@tdewolff/minify');
     config({'html-keep-document-tags': true})