fix: js optional chaining with bracket notation #757

[ksw2000]

The issue #757 occurs because both m.write(optChainBytes) and the branch inside if isIdent := js.AsIdentifierName(lit.Data[1 : len(lit.Data)-1]); isIdent call m.write(dotBytes), which can result in writing two dots .. simultaneously, causing an error.

The solution is to use an additional boolean variable to control and prevent writing two dots simultaneously. I have also added unit tests to verify this fix and replaced the deprecated ioutil package by os.

[tdewolff]

Thank you very much for the research and the PR! One nitpick is that there is no need for a new boolean variable, you can simply use expr.Optional. Could you update that so I can merge the PR?

…

On Thu, Oct 24, 2024, 04:48 Kashiwa ***@***.***> wrote: The issue #757 <#757> occurs because both m.write(optChainBytes) and the branch inside if isIdent := js.AsIdentifierName(lit.Data[1 : len(lit.Data)-1]); isIdent call m.write(dotBytes), which can result in writing two dots .. simultaneously, causing an error. The solution is to use an additional boolean variable to control and prevent writing two dots simultaneously. I have also added unit tests to verify this fix and replaced the deprecated ioutil package by os. ------------------------------ You can view, comment on, or merge this pull request online at: #758 Commit Summary - 56a9bac <56a9bac> fix: optional chaining with bracket notation #757 File Changes (2 files <https://github.com/tdewolff/minify/pull/758/files>) - *M* js/js.go <https://github.com/tdewolff/minify/pull/758/files#diff-f79a90454acddbb6114ba5bc6a2ffc1f4c95cd98f414fe9380dc20a445c05050> (8) - *M* js/js_test.go <https://github.com/tdewolff/minify/pull/758/files#diff-b020b34d46b4d0f669f353bc7c86da25409102b1cb7de8b1809b42e589d17d5b> (5) Patch Links: - https://github.com/tdewolff/minify/pull/758.patch - https://github.com/tdewolff/minify/pull/758.diff — Reply to this email directly, view it on GitHub <#758>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKOGHXWKOFLYLC5LBODI6DZ5CQ4NAVCNFSM6AAAAABQQOOP5CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTANZWGM4DEMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[tdewolff]

I've merged the PR and updated it, releasing new version now.