Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish update to Ionic 6 #547

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Conversation

Janaka-Steph
Copy link
Collaborator

Migration doc: https://ionicframework.com/docs/intro/upgrading-to-ionic-6#react

  • Update to @ionic/react@6 and @ionic/react-router@6 were missing.
  • Calling setupIonicReact were missing
  • Now we need to close the modals explicitly.
  • Update other libs minor versions.

New issue with IonRefresher (pull down to refresh): Uncaught (in promise) TypeError: contentEl.componentOnReady is not a function (will fix later on)

Please review @tiero

@Janaka-Steph Janaka-Steph merged commit a191bb7 into tdex-network:master Aug 19, 2022
@Janaka-Steph Janaka-Steph deleted the ionic-6 branch August 21, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant