This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Sync main and master #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous oversight.
* added support for consent for Taboola amp-analytics * fixed the consent substitution variable name * fixed the consent substitution name * fixed unit tests
* Types: fix all type parse errors * self nits * run prettier * fix a new parse error, make low-bar target
* types: shorthand for |null * a few more * fix test
Co-authored-by: Raghu Simha <rsimha@amp.dev>
* Clean up directory globs * Move src/core srcs+externs to const arrays * Exclude fetch/get-bounding-client-rect for now * Provide extern for promise-pjs polyfill * Fix types and add comments in abort-controller * Fix types and add comments in intersection-observer-stub * Remove @Suppress {checkTypes} from promise * Fix @this type for document.contains() polyfill * Remove unneeded typecast to unknown * Fix types and add comments in resize-observer-stub * Fix types and add comments in custom-elements * Add ! * Fix types in get-bounding-client-rect * Add more ! * Lint fixes * Allow custom-element.externs.js to use window * Revert no-op JSDoc changes * Remove connected callback externs and typecast instead * Clean up typedefs for observer stubs * Fix typo * Dedupe typedef
Following an update to the Brightcove Player's AMP support plugin, this update makes sure autoplay is handled correctly in all cases. - Removes any autoplay query param, including the interim autoplay=false - Distinguishes play messages sent through postmessage which are autoplay requests
Extract a wrapper to add video action buttons to an AMP Storybook. https://user-images.githubusercontent.com/254946/117086191-c4e6d700-ad00-11eb-95ff-f9e3b51caf2b.png
…ition (#34087) * Add package.json for all bento components with npm definition * Add newline at end of file * Fix indentation * Newline at end of file * Fix newline * Add recently published timeago, update NPM definitions * Remove package for render, sidebar, twitter which are not published * Update version for amp-timeago package
Rename `postMessage` method names so that they're uniform with `VideoIframe`'s. This simplifies the upcoming Bento implementation.
We can more simply allow `extensions/**` files to import specific files from `amp-video/1.0`. It should be ok in any case.
* runtime: allow for iterator polyfill * Empty commit * lint!
* Do not override user given height until message gives one * Support tweetid directly * Support bootstrap directly * Add unit tests * Support momentid directly * Add Storybook samples for additional options * Use Sinon syntax for spying on setter
The existing file `test-amp-ima-video.js` is a misnomer since it does not actually test the `<amp-ima-video>` element, only what it loads inside the frame. Accordingly, rename `test-amp-ima-video.js` as `test-ima-video-internal.js`. Also remove stubs specific to the AMP runtime, since it doesn't run inside the iframe.
* Remove Error classification * Left over let declaration * Remove jse error field
* Update OWNERS * Update OWNERS
* Update file naming from mjs to module * import exports should be in alphabetical order * Rename helper function
…gName` (#34312) * Switch based on data-embed-as versus tag name * Update tests * Update FacebookComments * Allow dependency on enum * Remove staticProps * Update all the tests * Remove dupe * Import userAssert * Allow dependency on enum
* ✨ Supports locale options for localeString in amp-date-display. * Allow user to customize locale options for localeString, the options setting is same as [Date.toLocaleString](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString#syntax) parameter. * [amp-date-display] Moves localeOptions from json type to data-options-*. * [amp-date-display] Tests and content imporvements. - Added invalid test cases. - Throws user error if invalid data-options-* param is provided. - Updated data-options-* readme doc. - Added new lines to .out validator files. - Applied reviewer suggestions.
…he next (#34569) Co-authored-by: Raghu Simha <rsimha@amp.dev>
* Remove the need to explicitly specify extern globs * Add clarifying comment * Allow type-check target to just be a list of globs * Update type * More explanatory comments * More comments
* Video cache for amp-video[src]. * Update extensions/amp-video/0.1/video-cache.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Update extensions/amp-video/0.1/video-cache.js * Import iterateCursor. * Reviews. Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
* allowing add data-attributes * using dataset for shorter code * fixing error use of style to style elements is forbidden * fixing default attribute values * removing sizes * allowing use min height * fixing banner alignment * fixing test * fixing prettier validation * fixing prettier validation
…hing (#34586) * update node script * lint * pr comments * lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.