SSP-1752: add new freemarker method to search first value in array #29
Conversation
| import freemarker.template.TemplateModelException | ||
|
|
||
| @tailrec | ||
| private def findChildNode(parent: JsonNode, fullPath: String): JsonNode = { |
There was a problem hiding this comment.
is it possible that parent==null and this trows a NPE?
There was a problem hiding this comment.
If the path of the parent does not exist, the check on the condition will be false and a TemplateModelException Value not found .. will be thrown. Like mentioned in Jackson documentation, here is the return type of the findPathmethod : Value of first matching node found; or if not found, a "missing node" (non-null instance that has no value)
| } | ||
|
|
||
| private def extractPathAndValueFromCondition(filteredChildCondition: String): (String, String) = { | ||
| val splitFilteredChildCondition = filteredChildCondition.split("==").map(_.trim) |
There was a problem hiding this comment.
mmm. I guess that it could be more generic by using JsonPath here, with the correct lib.
There was a problem hiding this comment.
This is exactly the mechanism i wanted to do with a Json path filter : json-path/JsonPath#272 i.e use an index on a filtered array with jsonPath. But as you can see, it is not possible as of now with JsonPath syntax. That is why i use a custom method to handle this problem.
…sed on a condition on the child
|
|
||
| override def exec(arguments: util.List[_]): SimpleScalar = { | ||
| if (arguments.size() != 3) { | ||
| throw new TemplateModelException("Wrong arguments : 3 expected : array node, filtered child condition, wanted node )") |
There was a problem hiding this comment.
bonus parenthesis at the end ?
| if (arguments.size() != 3) { | ||
| throw new TemplateModelException("Wrong arguments : 3 expected : array node, filtered child condition, wanted node )") | ||
| } | ||
| arguments.asScala.toList match { |
There was a problem hiding this comment.
As i can only apply getAsString on a SimpleScalar, it would be like this i think : arguments.asScala.toList.collect { case s: SimpleScalar => s.getAsString } match {
| if (filteredChild.textValue() == filteredChildValue) { | ||
| Some(findChildNode(parentNode, wantedChildPath).textValue()) | ||
| } else None | ||
| }.headOption match { |
There was a problem hiding this comment.
This part would be clearer in two steps
arrayNode.elements().asScala
.find(findChildNode(_, filteredChildPath).textValue() == filteredChildValue)
.map(findChildNode(_, wantedChildPath).textValue())
| val childNodes = fullPath.split('.') | ||
| if (childNodes.length == 1) | ||
| parent.findPath(fullPath) | ||
| else findChildNode(parent.findPath(childNodes.head), childNodes.tail.mkString(".")) |
There was a problem hiding this comment.
either keep both as one liners, or use a newline for both
| private def extractPathAndValueFromCondition(filteredChildCondition: String): (String, String) = { | ||
| val splitFilteredChildCondition = filteredChildCondition.split("==").map(_.trim) | ||
| if (splitFilteredChildCondition.length != 2) throw new TemplateModelException("Filtered child condition should be like this : car.color == red") | ||
| (splitFilteredChildCondition(0), splitFilteredChildCondition(1)) |
There was a problem hiding this comment.
filteredChildCondition.split("==").map(_.trim).toList match {
case path :: value :: Nil => (path, value)
case _ => throw new TemplateModelException("Filtered child condition should be like this : car.color == red")
}
| } | ||
|
|
||
| private def extractPathAndValueFromCondition(filteredChildCondition: String): (String, String) = { | ||
| val splitFilteredChildCondition = filteredChildCondition.split("==").map(_.trim) |
| val (array, filteredChildCondition, wantedChildPath) = (a1.getAsString, a2.getAsString, a3.getAsString) | ||
| val arrayNode = requestBody.findPath(array) | ||
| if (!arrayNode.isArray) throw new TemplateModelException("First arg should be an array node") | ||
| val (filteredChildPath, filteredChildValue) = extractPathAndValueFromCondition(filteredChildCondition) |
There was a problem hiding this comment.
This code deserves more space to make it more readable. Use some newline maybe ?
The new freemarker method allow to do this kind of thing, based on the JSON : (fyi, it only works on a condition with a string filter)
{ "cars": [ { "details": { "brand": "lexus", "color": "black" } }, { "details": { "brand": "citroen", "color": "red" } } ] }I want the color of the car which have the 'citroen' brand :
findFirstInArray("cars", "details.color == black", "details.brand")will return"lexus"