-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify clap derive definition #221
Conversation
f071e88
to
bffffd5
Compare
Hi, we discussed automatically parsed field names here: #108 (comment) I'd tend towards keeping the explicit commands, mostly for consistency and because this way people can read/grep the commands without knowing how the clap auto-generated flag names work. For example, if someone wants to know how the Do you disagree with that? |
bffffd5
to
4cf4e68
Compare
Nice, I didn't know about this option. Unfortunately it causes a line wrap because it's a bit more verbose: vs @niklasmohrin what's your opinion, worth it or not? I don't think the |
Something rubs me the wrong way when looking at the explicit version, but I cannot argue with your standpoint 😅 |
Regarding One potential gain is if we switch to clap-generated completion which completes |
That's a very good point, I'm convinced 😄 |
One more thought - should we leave a comment in code with a brief rationale for leaving flag names explicit? |
@tranzystorek-io thank you for the updates! Yes, such a comment would be helpful. Would you like to add one? Afterwards this should be ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Highlights:
Makeshort
andlong
attributes automatically parse field namespossible_values
render
field type toPathBuf