Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Excel opening files with AutoFilter data #792

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

neddy299
Copy link
Contributor

@neddy299 neddy299 commented Jan 3, 2024

Microsoft Excel is unable to open xlsx generated Excel files that contain AutoFilter data. This fix saves the autoFilter XML tag after sheetData and the Excel files work as expected.

Addresses the following issues

@ghost
Copy link

ghost commented Jan 3, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Owner

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@tealeg tealeg merged commit 1f3b461 into tealeg:master Jan 3, 2024
2 checks passed
@tealeg
Copy link
Owner

tealeg commented Jan 3, 2024

Thanks @neddy299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants