refactor: (#716) 사용하지 않는 메서드 제거

team-aliens · Aug 19, 2024 · 2f2ae54 · 2f2ae54
1 parent 0e2676c
commit 2f2ae54
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/dms-core/src/main/kotlin/team/aliens/dms/domain/student/service/GetStudentService.kt b/dms-core/src/main/kotlin/team/aliens/dms/domain/student/service/GetStudentService.kt
@@ -38,8 +38,6 @@ interface GetStudentService {
 
     fun getStudentsBySchoolId(schoolId: UUID): List<Student>
 
-    fun getAllStudentWithMinusPoint(): List<Pair<UUID, Int>>
-
     fun getAllStudentsByIdsIn(studentIds: List<UUID>): List<Student>
 
     fun getGcnUpdatedStudent(

diff --git a/dms-core/src/main/kotlin/team/aliens/dms/domain/student/service/GetStudentServiceImpl.kt b/dms-core/src/main/kotlin/team/aliens/dms/domain/student/service/GetStudentServiceImpl.kt
@@ -20,7 +20,6 @@ import java.util.function.Function
 class GetStudentServiceImpl(
     private val securityPort: SecurityPort,
     private val queryStudentPort: QueryStudentPort,
-    private val queryPointHistoryPort: QueryPointHistoryPort,
     private val queryOutingApplicationPort: QueryOutingApplicationPort,
 ) : GetStudentService {
 
@@ -69,15 +68,6 @@ class GetStudentServiceImpl(
     override fun getStudentsBySchoolId(schoolId: UUID) =
         queryStudentPort.queryStudentsBySchoolId(schoolId)
 
-    override fun getAllStudentWithMinusPoint(): List<Pair<UUID, Int>> =
-        queryStudentPort.queryAllStudentsByName("").map { student ->
-            val minusTotalPoint = queryPointHistoryPort.queryBonusAndMinusTotalPointByStudentGcnAndName(
-                gcn = student.gcn,
-                studentName = student.name
-            ).second
-            Pair(student.id, minusTotalPoint)
-        }
-
     override fun getAllStudentsByIdsIn(studentIds: List<UUID>) =
         queryStudentPort.queryAllStudentsByIdsIn(studentIds)
             .also { students ->