Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#679) 동행자가 내 외출 신청 조회 쿼리 버그 수정 #681

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Jul 11, 2024

작업 내용 설명

  • 외출 신청 동행자의 내 외출 신청 조회 쿼리 결과 수정

주요 변경 사항

  • 신청자, 동행자 쿼리를 하나로 병합
  • 쿼리 로직 수정 (자신이 포함된 외출 그룹에서 결과물에 자신 제외)
  • queryCurrentOutingApplicationAsCompanionVO 쿼리 삭제

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 added the 👾bug 버그가 발생한 경우 label Jul 11, 2024
@zios0707 zios0707 self-assigned this Jul 11, 2024
@zios0707 zios0707 linked an issue Jul 11, 2024 that may be closed by this pull request
1 task
@zios0707 zios0707 changed the title Fix/679 current outing application merge: (#679) 동행자가 내 외출 신청 조회 쿼리 버그 수정 Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 3.44%. Comparing base (e19dc35) to head (e33bf96).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #681      +/-   ##
============================================
+ Coverage       3.38%   3.44%   +0.05%     
  Complexity        84      84              
============================================
  Files            611     611              
  Lines           8474    8327     -147     
  Branches         205     205              
============================================
  Hits             287     287              
+ Misses          8176    8029     -147     
  Partials          11      11              
Files Coverage Δ
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% <ø> (ø)
...domain/outing/spi/vo/CurrentOutingApplicationVO.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...g/repository/vo/QueryCurrentOutingApplicationVO.kt 0.00% <0.00%> (ø)
...s/dms/domain/outing/dto/response/OutingResponse.kt 0.00% <0.00%> (ø)
...ting/usecase/GetCurrentOutingApplicationUseCase.kt 0.00% <0.00%> (ø)
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19dc35...e33bf96. Read the comment docs.

@zios0707 zios0707 requested review from 4mjeo and rlaisqls July 12, 2024 02:57
@zios0707 zios0707 requested a review from ilyoil2 July 15, 2024 01:34
@zios0707 zios0707 force-pushed the fix/679-current-outing-application branch from 66e9529 to e33bf96 Compare July 30, 2024 06:20
Copy link

sonarcloud bot commented Jul 30, 2024

@zios0707 zios0707 merged commit 0bfc0e4 into develop Jul 30, 2024
4 checks passed
@zios0707 zios0707 deleted the fix/679-current-outing-application branch July 30, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

동행자가 내 외출 신청 조회시 쿼리 오류
4 participants