Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: publishNotificationToApplicant 사용으로 변경 #706

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Aug 11, 2024

작업 내용 설명

  • publishNotification -> publishNotificationToApplicant 메서드 사용으로 변경

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@4mjeo 4mjeo added the 👾bug 버그가 발생한 경우 label Aug 11, 2024
@4mjeo 4mjeo self-assigned this Aug 11, 2024
@4mjeo 4mjeo linked an issue Aug 11, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Aug 11, 2024

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (76e6464) to head (85c505e).

Files Patch % Lines
...ms/domain/point/service/CommandPointServiceImpl.kt 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #706      +/-   ##
============================================
- Coverage       3.39%   3.39%   -0.01%     
  Complexity        84      84              
============================================
  Files            611     611              
  Lines           8457    8463       +6     
  Branches         205     206       +1     
============================================
  Hits             287     287              
- Misses          8159    8165       +6     
  Partials          11      11              
Files Coverage Δ
...ms/domain/point/service/CommandPointServiceImpl.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e6464...85c505e. Read the comment docs.

@4mjeo 4mjeo merged commit 76da690 into develop Aug 12, 2024
4 checks passed
@4mjeo 4mjeo deleted the bug/704-update-publishNotification-method branch August 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

publishNotification -> publishNotificationToApplicant 메서드 변경
2 participants