Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#705) 외출 신청 동행자 알람 미발행 버그 수정 #707

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Aug 12, 2024

작업 내용 설명

  • 디바이스 토큰 쿼리 변수 수정
  • 로직, 쿼리 향상

주요 변경 사항

  • queryDeviceTokensByUserIds 쿼리 추가

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 added the 👾bug 버그가 발생한 경우 label Aug 12, 2024
@zios0707 zios0707 self-assigned this Aug 12, 2024
@zios0707 zios0707 linked an issue Aug 12, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 3.38%. Comparing base (76da690) to head (12dd7ea).

Files Patch % Lines
...ence/notification/DeviceTokenPersistenceAdapter.kt 0.00% 10 Missing ⚠️
.../domain/outing/service/CommandOutingServiceImpl.kt 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #707      +/-   ##
============================================
- Coverage       3.39%   3.38%   -0.01%     
  Complexity        84      84              
============================================
  Files            611     611              
  Lines           8463    8470       +7     
  Branches         206     207       +1     
============================================
  Hits             287     287              
- Misses          8165    8172       +7     
  Partials          11      11              
Files Coverage Δ
.../domain/outing/service/CommandOutingServiceImpl.kt 0.00% <0.00%> (ø)
...ence/notification/DeviceTokenPersistenceAdapter.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76da690...12dd7ea. Read the comment docs.

@zios0707 zios0707 force-pushed the bug/705-application-companion-notification branch from 0963e59 to 12dd7ea Compare August 12, 2024 10:26
Copy link

sonarcloud bot commented Aug 12, 2024

@zios0707 zios0707 merged commit 0a1f58d into develop Aug 12, 2024
4 checks passed
@zios0707 zios0707 deleted the bug/705-application-companion-notification branch August 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

외출 신청시 동행자 알람 오류
2 participants