Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#716) 학생 조회 api 에 schoolId 추가 #717

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Aug 19, 2024

작업 내용 설명

  • 학생 조회 api가 다른 학교 학생까지 조회되는 버그를 수정
  • [ ]

주요 변경 사항

  • 사용하지 않는 메서드들 까지 정리함

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the 👾bug 버그가 발생한 경우 label Aug 19, 2024
@ilyoil2 ilyoil2 self-assigned this Aug 19, 2024
@ilyoil2 ilyoil2 linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Aug 19, 2024

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (0e2676c) to head (82659e9).
Report is 4 commits behind head on develop.

Files Patch % Lines
...in/student/usecase/StudentGetAllStudentsUseCase.kt 0.00% 4 Missing ⚠️
...s/persistence/student/StudentPersistenceAdapter.kt 0.00% 3 Missing ⚠️
...ms/domain/student/service/GetStudentServiceImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #717   +/-   ##
=========================================
  Coverage       3.39%   3.39%           
  Complexity        84      84           
=========================================
  Files            611     611           
  Lines           8465    8443   -22     
  Branches         205     205           
=========================================
  Hits             287     287           
+ Misses          8167    8145   -22     
  Partials          11      11           
Files Coverage Δ
...ns/dms/domain/student/service/GetStudentService.kt 0.00% <ø> (ø)
...ns/dms/domain/tag/service/CommandTagServiceImpl.kt 0.00% <ø> (ø)
...aliens/dms/domain/tag/service/GetTagServiceImpl.kt 0.00% <ø> (ø)
...ms/persistence/tag/StudentTagPersistenceAdapter.kt 0.00% <ø> (ø)
...liens/dms/persistence/tag/TagPersistenceAdapter.kt 0.00% <ø> (ø)
...ms/domain/student/service/GetStudentServiceImpl.kt 0.00% <0.00%> (ø)
...s/persistence/student/StudentPersistenceAdapter.kt 0.00% <0.00%> (ø)
...in/student/usecase/StudentGetAllStudentsUseCase.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2676c...82659e9. Read the comment docs.

@ilyoil2 ilyoil2 merged commit 463abed into develop Aug 19, 2024
4 checks passed
@ilyoil2 ilyoil2 deleted the fix/716-get-all-student-api-add-schoolId branch August 19, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

학생 조회 api 에 schoolId 추가
3 participants