Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: (#757) Jackson 생성자 지정 #758

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Sep 21, 2024

작업 내용 설명

  • 기본생성자가 없어서 역직렬화 문제가 발생했습니다.
  • Jackson에서 사용할 생성자를 지정해주었습니다.

주요 변경 사항

  • Kotlin Jackson 도입 실패..

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@4mjeo 4mjeo added the 👾bug 버그가 발생한 경우 label Sep 21, 2024
@4mjeo 4mjeo self-assigned this Sep 21, 2024
@4mjeo 4mjeo linked an issue Sep 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 3.15%. Comparing base (9b4f349) to head (64dda56).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...m/aliens/dms/domain/student/dto/StudentResponse.kt 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #758   +/-   ##
=========================================
  Coverage       3.15%   3.15%           
  Complexity        85      85           
=========================================
  Files            654     654           
  Lines           9125    9125           
  Branches         212     212           
=========================================
  Hits             288     288           
  Misses          8828    8828           
  Partials           9       9           
Flag Coverage Δ
3.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% <ø> (ø)
...m/aliens/dms/domain/student/dto/StudentResponse.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4f349...64dda56. Read the comment docs.

Copy link

sonarcloud bot commented Sep 21, 2024

@4mjeo 4mjeo merged commit 931821d into develop Sep 21, 2024
4 checks passed
@4mjeo 4mjeo deleted the fix/757-get-all-student-bug branch September 21, 2024 13:55
@@ -46,17 +49,17 @@ data class StudentNameResponse(
val name: String
)

data class StudentDetailsResponse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4mjeo 궁금한 부분이 있는데

  1. 역직렬화시에 기본생성자가 필요한 경우가 StudentDetailsResponse 밖에 없었던건가요?
  2. 그리고 기본생성자가 없는게 문제라면 이 글처럼 필드 기본값을 넣어주거나, 기본생성자를 직접 정의하는 방법이 더 깔끔할 것 같은데 @JsonCreator를 사용하신 이유가 따로 있나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

학생 전체 조회 오류 수정
3 participants