Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#767) reason nullable #768

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Sep 22, 2024

작업 내용 설명

  • reason을 삭제했습니다
  • outingType을 추가했습니다

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the 👾bug 버그가 발생한 경우 label Sep 22, 2024
@ilyoil2 ilyoil2 self-assigned this Sep 22, 2024
@ilyoil2 ilyoil2 linked an issue Sep 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 3.16%. Comparing base (f521316) to head (332ecc9).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 0.00% 2 Missing ⚠️
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #768   +/-   ##
=========================================
  Coverage       3.16%   3.16%           
  Complexity        85      85           
=========================================
  Files            652     652           
  Lines           9102    9099    -3     
  Branches         213     212    -1     
=========================================
  Hits             288     288           
+ Misses          8805    8802    -3     
  Partials           9       9           
Flag Coverage Δ
3.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% <ø> (ø)
...e/outing/repository/vo/QueryOutingApplicationVO.kt 0.00% <ø> (ø)
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 15.52% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f521316...332ecc9. Read the comment docs.

Copy link

sonarcloud bot commented Sep 22, 2024

@ilyoil2 ilyoil2 merged commit 738d907 into develop Sep 24, 2024
4 checks passed
@ilyoil2 ilyoil2 deleted the fix/767-outing-excel-nullable branch September 24, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

엑셀출력 에러 수정
2 participants