Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#769) 봉사 활동 Enum 수정 및 로직 일부 수정 #771

Merged
merged 16 commits into from
Sep 26, 2024

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Sep 25, 2024

작업 내용 설명

  • 입력 필드에서 바로 Enum으로 변환하여 처리
  • 바뀌지 않은 Enum 명 변경
  • Enum 일부 변경
  • 근황 조회 Response 구조 및 오류 수정
  • 신청 중복 예외 처리 추가

주요 변경 사항

  • Available_grade의 길이를 14에서 16으로 증가 (flyway 사용, jpa 개체 수정)
  • 쿼리 좀 변경

결과물

image
image
image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 self-assigned this Sep 25, 2024
@zios0707 zios0707 linked an issue Sep 25, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes missing coverage. Please review.

Project coverage is 3.15%. Comparing base (29a17cd) to head (caf375f).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...olunteer/VolunteerApplicationPersistenceAdapter.kt 0.00% 17 Missing ⚠️
...ain/volunteer/service/CheckVolunteerServiceImpl.kt 0.00% 8 Missing ⚠️
.../domain/volunteer/exception/VolunteerExceptions.kt 0.00% 6 Missing ⚠️
...eam/aliens/dms/domain/volunteer/model/Volunteer.kt 0.00% 6 Missing ⚠️
.../team/aliens/dms/global/security/SecurityConfig.kt 0.00% 6 Missing ⚠️
...volunteer/dto/request/CreateVolunteerWebRequest.kt 0.00% 6 Missing ⚠️
...volunteer/dto/request/UpdateVolunteerWebRequest.kt 0.00% 6 Missing ⚠️
...domain/volunteer/dto/response/VolunteerResponse.kt 0.00% 5 Missing ⚠️
.../domain/volunteer/usecase/ApplyVolunteerUseCase.kt 0.00% 5 Missing ⚠️
...liens/dms/domain/volunteer/model/AvailableGrade.kt 0.00% 4 Missing ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #771      +/-   ##
============================================
- Coverage       3.16%   3.15%   -0.02%     
  Complexity        85      85              
============================================
  Files            652     653       +1     
  Lines           9099    9134      +35     
  Branches         212     212              
============================================
  Hits             288     288              
- Misses          8802    8837      +35     
  Partials           9       9              
Flag Coverage Δ
3.15% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tlin/team/aliens/dms/domain/tag/dto/TagResponse.kt 0.00% <ø> (ø)
...aliens/dms/domain/volunteer/VolunteerWebAdapter.kt 0.00% <ø> (ø)
...domain/volunteer/usecase/DeleteVolunteerUseCase.kt 0.00% <0.00%> (ø)
...lunteer/usecase/QueryAvailableVolunteersUseCase.kt 0.00% <0.00%> (ø)
...rsistence/volunteer/VolunteerPersistenceAdapter.kt 0.00% <0.00%> (ø)
...in/volunteer/dto/request/CreateVolunteerRequest.kt 0.00% <0.00%> (ø)
...in/volunteer/dto/request/UpdateVolunteerRequest.kt 0.00% <0.00%> (ø)
...n/volunteer/service/CommandVolunteerServiceImpl.kt 0.00% <0.00%> (ø)
...s/dms/domain/volunteer/service/VolunteerService.kt 0.00% <0.00%> (ø)
...in/volunteer/spi/vo/CurrentVolunteerApplicantVO.kt 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a17cd...caf375f. Read the comment docs.

@zios0707 zios0707 changed the title merge: (#769) 봉사 활동 Enum 수정 merge: (#769) 봉사 활동 Enum 수정 및 로직 일부 수정 Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

@zios0707 zios0707 merged commit 3879229 into develop Sep 26, 2024
3 of 4 checks passed
@zios0707 zios0707 deleted the fix/769-volunteer branch September 26, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

봉사활동 버그 수정
3 participants