Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#774) 봉사 활동 목록 조회 Response 에 CurrentApplicants 추가 #775

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Sep 27, 2024

작업 내용 설명

  • response에 currentApplicants 필드 추가
  • 학생 조회 response에 status 필드 추가

주요 변경 사항

  • VO 추가

  • Response of 메서드의 매개 변수 클래스를 VO 로 변경

  • status ENUM 추가 (노션에 명세 해놨습니다)

  • response 에 status가 추가됨에 따라 approved 필드를 제거

  • 쿼리의 반환값을 List<Pair<>> 에서 List<Triple<>> 로 변경

  • 현재 봉사자에 따른 신청제약은 서버에서 처리하지 않습니다.

결과물

image
image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 self-assigned this Sep 27, 2024
@zios0707 zios0707 linked an issue Sep 27, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 129 lines in your changes missing coverage. Please review.

Project coverage is 3.11%. Comparing base (13045c9) to head (3cf2c2c).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...domain/volunteer/dto/response/VolunteerResponse.kt 0.00% 30 Missing ⚠️
...rsistence/volunteer/VolunteerPersistenceAdapter.kt 0.00% 25 Missing ⚠️
...olunteer/spi/vo/VolunteerWithCurrentApplicantVO.kt 0.00% 23 Missing ⚠️
...ository/vo/QueryVolunteerWithCurrentApplicantVO.kt 0.00% 13 Missing ⚠️
...olunteer/VolunteerApplicationPersistenceAdapter.kt 0.00% 9 Missing ⚠️
...main/volunteer/model/VolunteerApplicationStatus.kt 0.00% 8 Missing ⚠️
...omain/volunteer/service/GetVolunteerServiceImpl.kt 0.00% 7 Missing ⚠️
...omain/volunteer/usecase/UnapplyVolunteerUseCase.kt 0.00% 6 Missing ⚠️
...in/volunteer/spi/vo/CurrentVolunteerApplicantVO.kt 0.00% 2 Missing ⚠️
.../repository/vo/QueryCurrentVolunteerApplicantVO.kt 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #775      +/-   ##
============================================
- Coverage       3.14%   3.11%   -0.04%     
  Complexity        85      85              
============================================
  Files            653     656       +3     
  Lines           9144    9240      +96     
  Branches         212     215       +3     
============================================
  Hits             288     288              
- Misses          8847    8943      +96     
  Partials           9       9              
Files with missing lines Coverage Δ
...olunteer/usecase/ManagerGetAllVolunteersUseCase.kt 0.00% <0.00%> (ø)
...lunteer/usecase/QueryAvailableVolunteersUseCase.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...aliens/dms/domain/volunteer/VolunteerWebAdapter.kt 0.00% <0.00%> (ø)
...in/volunteer/spi/vo/CurrentVolunteerApplicantVO.kt 0.00% <0.00%> (ø)
.../repository/vo/QueryCurrentVolunteerApplicantVO.kt 0.00% <0.00%> (ø)
...omain/volunteer/usecase/UnapplyVolunteerUseCase.kt 0.00% <0.00%> (ø)
...omain/volunteer/service/GetVolunteerServiceImpl.kt 0.00% <0.00%> (ø)
...main/volunteer/model/VolunteerApplicationStatus.kt 0.00% <0.00%> (ø)
...olunteer/VolunteerApplicationPersistenceAdapter.kt 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13045c9...3cf2c2c. Read the comment docs.

@4mjeo
Copy link
Member

4mjeo commented Sep 30, 2024

혹시 현재 봉사자를 나타내는 코드도 추가해주실 수 있나요?

@zios0707
Copy link
Collaborator Author

zios0707 commented Oct 3, 2024

혹시 현재 봉사자를 나타내는 코드도 추가해주실 수 있나요?

결과물에 코드를 보여달라는 의미이신가요?

@zios0707 zios0707 requested a review from ilyoil2 October 3, 2024 12:58
@zios0707 zios0707 added the feat 새로운 기능을 추가 할 경우 label Oct 4, 2024
@zios0707 zios0707 force-pushed the feat/774-volunteer-applicants branch from 3bbd443 to 3cf2c2c Compare October 6, 2024 23:07
Copy link

sonarcloud bot commented Oct 6, 2024

@zios0707 zios0707 requested a review from ilyoil2 October 7, 2024 06:03
@zios0707 zios0707 merged commit 0e43725 into develop Oct 7, 2024
3 of 4 checks passed
@zios0707 zios0707 deleted the feat/774-volunteer-applicants branch October 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

봉사 활동 조회 수정
3 participants