-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge: (#774) 봉사 활동 목록 조회 Response 에 CurrentApplicants 추가 #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zios0707
requested review from
rlaisqls,
tedsoftj1123,
alsdl0629,
ilyoil2 and
4mjeo
as code owners
September 27, 2024 04:40
Closed
2 tasks
혹시 현재 봉사자를 나타내는 코드도 추가해주실 수 있나요? |
ilyoil2
approved these changes
Sep 30, 2024
결과물에 코드를 보여달라는 의미이신가요? |
zios0707
force-pushed
the
feat/774-volunteer-applicants
branch
from
October 6, 2024 23:07
3bbd443
to
3cf2c2c
Compare
Quality Gate passedIssues Measures |
ilyoil2
reviewed
Oct 7, 2024
.../main/kotlin/team/aliens/dms/persistence/volunteer/VolunteerApplicationPersistenceAdapter.kt
Show resolved
Hide resolved
ilyoil2
approved these changes
Oct 7, 2024
4mjeo
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 설명
주요 변경 사항
VO 추가
Response of 메서드의 매개 변수 클래스를 VO 로 변경
status ENUM 추가 (노션에 명세 해놨습니다)
response 에 status가 추가됨에 따라 approved 필드를 제거
쿼리의 반환값을 List<Pair<>> 에서 List<Triple<>> 로 변경
현재 봉사자에 따른 신청제약은 서버에서 처리하지 않습니다.
결과물
체크리스트
관련 이슈