Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#785) volunteer content 삭제 #787

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Oct 8, 2024

작업 내용 설명

  • volunteer 엔티티에서 content를 삭제했습니다.
  • 그에 따라 volunteer 과 관련된 API 에서 content 를 삭제했습니다.

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@4mjeo 4mjeo added the refactor 코드 리팩토링 할 경우 label Oct 8, 2024
@4mjeo 4mjeo self-assigned this Oct 8, 2024
@4mjeo 4mjeo linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.11%. Comparing base (38fced8) to head (7951b72).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #787   +/-   ##
=========================================
  Coverage       3.10%   3.11%           
  Complexity        85      85           
=========================================
  Files            656     656           
  Lines           9264    9241   -23     
  Branches         215     215           
=========================================
  Hits             288     288           
+ Misses          8967    8944   -23     
  Partials           9       9           
Files with missing lines Coverage Δ
...in/volunteer/dto/request/CreateVolunteerRequest.kt 0.00% <ø> (ø)
...in/volunteer/dto/request/UpdateVolunteerRequest.kt 0.00% <ø> (ø)
...domain/volunteer/dto/response/VolunteerResponse.kt 0.00% <ø> (ø)
...eam/aliens/dms/domain/volunteer/model/Volunteer.kt 0.00% <ø> (ø)
...olunteer/spi/vo/VolunteerWithCurrentApplicantVO.kt 0.00% <ø> (ø)
...domain/volunteer/usecase/CreateVolunteerUseCase.kt 0.00% <ø> (ø)
...domain/volunteer/usecase/UpdateVolunteerUseCase.kt 0.00% <ø> (ø)
...rsistence/volunteer/VolunteerPersistenceAdapter.kt 0.00% <ø> (ø)
...persistence/volunteer/entity/VolunteerJpaEntity.kt 0.00% <ø> (ø)
...ms/persistence/volunteer/mapper/VolunteerMapper.kt 0.00% <ø> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fced8...7951b72. Read the comment docs.

@ilyoil2
Copy link
Member

ilyoil2 commented Oct 9, 2024

image

❗여기에 있는 content도 삭제해주세요

@ilyoil2
Copy link
Member

ilyoil2 commented Oct 9, 2024

image

❗이것도 삭제해주세요

Copy link

sonarcloud bot commented Oct 9, 2024

@4mjeo 4mjeo merged commit 67e65a7 into develop Oct 9, 2024
4 checks passed
@4mjeo 4mjeo deleted the delete/785-delete-volunteer-content branch October 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

봉사 내용 컬럼 삭제
2 participants