-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ :: (#230) ํผ๋ ์ ๊ณ Slack ์ฐ๋ #114
Conversation
feed-domain/src/main/java/com/xquare/v1servicefeed/report/api/impl/ReportApiImpl.java
Outdated
Show resolved
Hide resolved
sendWebhookSpi.sendReportToSlack( | ||
new SlackReport(feed.getContent(), user.getName(), request.getContent()) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring EventListener ์์๋ณด๋ฉด ์ข์ ๊ฒ ๊ฐ์์ :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ต!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์๋ดค๋์ ? ์ด๋ค๊ฒ๊ฐ์์??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๊ฐ ์ ์ report๋ผ๋ ๋ ํฌ์งํ ๋ฆฌ์์๋ ์์ ๊ฐ์ ์ฝ๋๋ฅผ ์์ฑํ๋ ๊ฒฝํ์ด ์์ด์ ๊ทธ๋๋ Event Listener๋ฅผ ์ฌ์ฉํ ๊น ๊ณ ๋ฏผํ์๋๋ฐ
api ์๋ฃ๋๋๋ฐ๊น์ง ์๊ฐ๋ง ์ต์ ํํ๋ ค๋ฉด @async๋ง ์ฌ์ฉํด๋ ๊ด์ฐฎ์๊ฑฐ ๊ฐ๋ค ์๊ฐํ์๋๋ฐ ํน์ ์ด๋ป๊ฒ ์๊ฐํ์๋์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฌ๊ธฐ์ ๋ด๊ฐ ๋ง์ฝ EventListener๋ฅผ ์ฌ์ฉํ๋ค๋ฉด ์๊ฐ ์ต์ ํ๋ฅผ ์ด์ ๋ก ์ฌ์ฉํ์ง๋ ์์ ๊ฒ ๊ฐ์
๋ ์ค๋ฅด๋๊ฑฐ ์์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๊ณ ์ ์ฅ ์คํจํ๋ฉด ๊ธฐ์กด๋ Slack์ ์๋ ์๊ฐ๊ฑฐ๊ฐ์๋?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋๋ ์์กด์ฑ ์ด์ผ๊ธฐํ๋ถ๋ถ์ด๊ธด ํจ
์ ๊ณ ๋ฅผ ์ ์ฅํ๋ ์ ๋ ์ฌ๋์ ๋ณด๋ด๋์ ๋ฅผ ๊ตณ์ด ์ธ๋ถ์ ์ผ๋ก ์์์ผํ ์ด์ ๊ฐ ์๋๋ฐ, ์์กดํ๊ณ ์์ผ๋ EventListener๋ฅผ ์ฌ์ฉํ๋ฉด ์์กด์ฑ์ ์์จ ์ ์์ผ๋๊น(Dto ๋นผ๊ณ ) ์ง๊ธ๊ฐ์ ๊ตฌ์กฐ๋ ๊ด์ฐฎ์๋ฐ, ๋จ๋ฐฉํฅ ์์กด์ผ๋ก ๋ชจ๋๋ณ ์์กด์ด ์์ ๋ ๊ทธ ํ๋ฆ์ ์ญํํด์ ๋ญ๊ฐ ๋ฉ์์ง๋ฅผ ๋ณด๋ด์ผํ ๋๊ฐ ์๋๋ฐ, ๊ทธ๋ด ๋ ์ฌ์ฉํ๋ฉด ๊ฐ๊ฟ์
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ทธ๋ฌ๋ฉด ํ ๋ฒ ์ ์ฉํด์ ์์ ํด๋ณด๋๋ก ํ๊ฒ ์ต๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ ์ข ๋ค๋ฅธ ๊ด์ ์ด๊ธด ํจ
slack ์ฅ์ ์์ ์ ๊ณ ์๋น์ค์ ์ํฅ์ ์ค์ผํ๋? ์ง๊ธ ์ํ๋๋ก๋ฉด ์ฌ๋ ์ฅ์ ์์ ์ ๊ณ ๊ธฐ๋ฅ์ด ๋จนํต์ผํ
๋ฐ ๊ด์ฐฎ์๊ฐ?๋ ๊ณ ๋ฏผํด๋ณด๋ฉด ์ข์๋ฏ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ต!
์์ฒ๋ผ ํผ๋๋ฅผ ์ ๊ณ ํ์๋ Slack์ ์๋์ด ๊ฐ๋๋ก ๊ตฌ์ถํ์ฌ ๋นจ๋ฆฌ ํ์ธํ ์ ์๋๋ก ํ์ต๋๋ค.