Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#230) ํ”ผ๋“œ ์‹ ๊ณ  Slack ์—ฐ๋™ #114

Merged
merged 14 commits into from
Sep 11, 2023

Conversation

jeongho1209
Copy link
Member

@jeongho1209 jeongho1209 commented Sep 6, 2023

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-09-07 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 12 55 49

์œ„์ฒ˜๋Ÿผ ํ”ผ๋“œ๋ฅผ ์‹ ๊ณ ํ–ˆ์„๋•Œ Slack์— ์•Œ๋žŒ์ด ๊ฐ€๋„๋ก ๊ตฌ์ถ•ํ•˜์—ฌ ๋นจ๋ฆฌ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.

@jeongho1209 jeongho1209 added the ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค. label Sep 6, 2023
@jeongho1209 jeongho1209 self-assigned this Sep 6, 2023
Comment on lines +50 to +52
sendWebhookSpi.sendReportToSlack(
new SlackReport(feed.getContent(), user.getName(), request.getContent())
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring EventListener ์•Œ์•„๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•Œ์•„๋ดค๋‚˜์œ ? ์–ด๋–ค๊ฒƒ๊ฐ™์•„์š”??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ๊ฐ€ ์ „์— report๋ผ๋Š” ๋ ˆํฌ์ง€ํ† ๋ฆฌ์—์„œ๋„ ์œ„์™€ ๊ฐ™์€ ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ–ˆ๋˜ ๊ฒฝํ—˜์ด ์žˆ์–ด์„œ ๊ทธ๋•Œ๋„ Event Listener๋ฅผ ์‚ฌ์šฉํ• ๊นŒ ๊ณ ๋ฏผํ–ˆ์—ˆ๋Š”๋ฐ
api ์™„๋ฃŒ๋˜๋Š”๋ฐ๊นŒ์ง€ ์‹œ๊ฐ„๋งŒ ์ตœ์ ํ™”ํ•˜๋ ค๋ฉด @async๋งŒ ์‚ฌ์šฉํ•ด๋„ ๊ดœ์ฐฎ์„๊ฑฐ ๊ฐ™๋‹ค ์ƒ๊ฐํ–ˆ์—ˆ๋Š”๋ฐ ํ˜น์‹œ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ์„œ ๋‚ด๊ฐ€ ๋งŒ์•ฝ EventListener๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค๋ฉด ์‹œ๊ฐ„ ์ตœ์ ํ™”๋ฅผ ์ด์œ ๋กœ ์‚ฌ์šฉํ•˜์ง€๋Š” ์•Š์„ ๊ฒƒ ๊ฐ™์Œ
๋– ์˜ค๋ฅด๋Š”๊ฑฐ ์—†์Œ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹ ๊ณ  ์ €์žฅ ์‹คํŒจํ•˜๋ฉด ๊ธฐ์กด๋„ Slack์— ์•Œ๋žŒ ์•ˆ๊ฐˆ๊ฑฐ๊ฐ™์€๋””?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚˜๋Š” ์˜์กด์„ฑ ์ด์•ผ๊ธฐํ•œ๋ถ€๋ถ„์ด๊ธด ํ•จ
์‹ ๊ณ ๋ฅผ ์ €์žฅํ•˜๋Š” ์• ๋Š” ์Šฌ๋ž™์„ ๋ณด๋‚ด๋Š”์• ๋ฅผ ๊ตณ์ด ์„ธ๋ถ€์ ์œผ๋กœ ์•Œ์•„์•ผํ•  ์ด์œ ๊ฐ€ ์—†๋Š”๋ฐ, ์˜์กดํ•˜๊ณ ์žˆ์œผ๋‹ˆ EventListener๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด ์˜์กด์„ฑ์„ ์—†์•จ ์ˆ˜ ์žˆ์œผ๋‹ˆ๊นŒ(Dto ๋นผ๊ณ ) ์ง€๊ธˆ๊ฐ™์€ ๊ตฌ์กฐ๋Š” ๊ดœ์ฐฎ์€๋ฐ, ๋‹จ๋ฐฉํ–ฅ ์˜์กด์œผ๋กœ ๋ชจ๋“ˆ๋ณ„ ์˜์กด์ด ์žˆ์„ ๋•Œ ๊ทธ ํ๋ฆ„์„ ์—ญํ–‰ํ•ด์„œ ๋ญ”๊ฐ€ ๋ฉ”์‹œ์ง€๋ฅผ ๋ณด๋‚ด์•ผํ•  ๋•Œ๊ฐ€ ์žˆ๋Š”๋ฐ, ๊ทธ๋Ÿด ๋•Œ ์‚ฌ์šฉํ•˜๋ฉด ๊ฐœ๊ฟ€์ž„

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋Ÿฌ๋ฉด ํ•œ ๋ฒˆ ์ ์šฉํ•ด์„œ ์ˆ˜์ •ํ•ด๋ณด๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚œ ์ข€ ๋‹ค๋ฅธ ๊ด€์ ์ด๊ธด ํ•จ
slack ์žฅ์• ์‹œ์— ์‹ ๊ณ  ์„œ๋น„์Šค์— ์˜ํ–ฅ์„ ์ค˜์•ผํ•˜๋‚˜? ์ง€๊ธˆ ์ƒํƒœ๋Œ€๋กœ๋ฉด ์Šฌ๋ž™ ์žฅ์• ์‹œ์— ์‹ ๊ณ  ๊ธฐ๋Šฅ์ด ๋จนํ†ต์ผํ…๋ฐ ๊ดœ์ฐฎ์€๊ฐ€?๋„ ๊ณ ๋ฏผํ•ด๋ณด๋ฉด ์ข‹์„๋“ฏ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต!

@jeongho1209 jeongho1209 merged commit 8391754 into main Sep 11, 2023
1 check passed
@jeongho1209 jeongho1209 deleted the XQU-230-report-webhook-connect branch September 11, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์š”์ฒญ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants