Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YEL-192 [fix] notice path variable에 tag 추가 #417

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

hyeonjeongs
Copy link
Member

@hyeonjeongs hyeonjeongs commented Jan 29, 2024

☘️ Related Issue

  • resolves YEL-192

✅ Work description

  • tag에 대한 notice 조회
  • notice tag 대문자로 전달해줘야 noticeType에서 enum 인식가능

💡 PR point

@hyeonjeongs hyeonjeongs added feat 새로운 기능 구현 현정👕 labels Jan 29, 2024
@hyeonjeongs hyeonjeongs self-assigned this Jan 29, 2024
Copy link

github-actions bot commented Jan 29, 2024

Test Results

143 tests  ±0   143 ✅ ±0   10s ⏱️ +3s
 25 suites ±0     0 💤 ±0 
 25 files   ±0     0 ❌ ±0 

Results for commit bb793ed. ± Comparison against base commit f03c405.

♻️ This comment has been updated with latest results.

@hyeonjeongs hyeonjeongs requested a review from euije January 29, 2024 12:47
Copy link
Member

@euije euije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyeonjeongs hyeonjeongs merged commit db09386 into develop Jan 29, 2024
4 checks passed
@euije euije deleted the fix/YEL-192 branch February 2, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 구현 현정👕
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants