Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler Extension #19

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Profiler Extension #19

merged 9 commits into from
Jul 2, 2024

Conversation

nehlsen
Copy link
Contributor

@nehlsen nehlsen commented May 16, 2024

This PR drops a 🔥 extension for the Symfony Profiler. Now you can peep 👀 all the loaded fixtures, see how long each one took to load ⏱️, and check out the memory each one gobbled up 🧠. Straight fire! 🚀

@nehlsen nehlsen linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@lukadschaak lukadschaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix phpstan

@nehlsen
Copy link
Contributor Author

nehlsen commented Jun 11, 2024

@lukadschaak done! 💥

@nehlsen nehlsen marked this pull request as ready for review June 11, 2024 18:52
Copy link
Member

@jdreesen jdreesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 😍 Thank you very much!

Just some nits.

src/Profiler/DataCollector/FixtureLoaderCollector.php Outdated Show resolved Hide resolved
src/Profiler/EventListener/TimingSubscriber.php Outdated Show resolved Hide resolved
src/Profiler/FixtureReference/FixtureReference.php Outdated Show resolved Hide resolved
src/Profiler/FixtureReference/FixtureReferenceResolver.php Outdated Show resolved Hide resolved
src/Profiler/PerformanceInfo/PerformanceInfo.php Outdated Show resolved Hide resolved
src/Profiler/Timing/Timing.php Outdated Show resolved Hide resolved
src/Profiler/Timing/TimingCollector.php Outdated Show resolved Hide resolved
config/services.yaml Outdated Show resolved Hide resolved
nehlsen and others added 2 commits July 2, 2024 09:36
@nehlsen nehlsen merged commit e49bd1e into main Jul 2, 2024
5 checks passed
@nehlsen nehlsen deleted the feature/profiler-extension branch July 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiler Extension
3 participants