Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphere fix #44

Merged
merged 2 commits into from
Aug 8, 2024
Merged

sphere fix #44

merged 2 commits into from
Aug 8, 2024

Conversation

milesagraham
Copy link
Member

No description provided.

@milesagraham milesagraham merged commit e814ccb into main Aug 8, 2024
7 checks passed
@milesagraham milesagraham deleted the curved_surface branch August 8, 2024 11:12
Copy link
Member

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports don't look correct, what was wrong with them?

@milesagraham
Copy link
Member Author

milesagraham commented Aug 9, 2024

Nothing was wrong with them, but when I'm testing the script I need to remove the dot in the pycharm project, and forgot to put it back in before the pull request. Dumb error which I've since fixed directly on the main branch (not best practice I understand, but was quick). Teaches me to review things more before pulling and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants