This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
Fix issue with tests ending with Fatal (without summary) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Seems like you forgot to add the test file (this is why tests on travis fail) - can you add it? |
|
Sure, I can add them, but I'd be guessing as to what they should look like - the bug here is that the result of parsing this input is actually empty. |
|
I don't understand. The test log says:
You'll need to add this file (and same in data/out/xunit.net) If it's an empty file, add an empty file. |
Test binaries compiled with `go test -c` that encounter os.Exit or Fatal crash without a package summary. Previously, this caused the tests to not get reported properly. This commit fixes the issue.
tamird
changed the title
|
@tebeka updated courtesy of @jordanlewis |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can trigger when tests terminate with
log.Fataloros.Exit.This is an issue report in the form of a PR - currently this kind of failure results in nothing reported from go2xunit :(
@tebeka cc @jordanlewis @RaduBerinde (ccing because maybe we want to change our log.Fatal to panic at the end instead of os.Exit'ing).