Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid PropType warning on 1.4.0 #76

Closed
andrewmclagan opened this issue Mar 6, 2019 · 3 comments
Closed

Invalid PropType warning on 1.4.0 #76

andrewmclagan opened this issue Mar 6, 2019 · 3 comments

Comments

@andrewmclagan
Copy link
Contributor 

Warning: Invalid arguments supplied to oneOf, expected an array, got 3 arguments. A common mistake is to write oneOf(x, y, z) instead of oneOf([x, y, z]).

Seeming to come from

mui-downshift/src/index.js

Line 110 in 781fbb2

variant: PropTypes.oneOf('standard','filled','outlined'),
that was updated with this version.

PR coming
andrewmclagan added a commit to andrewmclagan/mui-downshift that referenced this issue Mar 6, 2019
@andrewmclagan
Invalid prop-type
eed86f1 
see issue techniq#76
@andrewmclagan andrewmclagan mentioned this issue Mar 6, 2019
Merged
@andrewmclagan
Copy link
Contributor Author

see PR #77

@cvanem
Copy link
Collaborator

cvanem commented Mar 6, 2019

@andrewmclagan Thanks for catching that. I don't use PropTypes much :)

@techniq
Copy link
Owner

techniq commented Mar 6, 2019

Fixed in 1.4.1. Thanks for the PR.

@techniq techniq closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@techniq @andrewmclagan @cvanem