Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

差分の詳細を算出しないモードの追加 #173

Closed
technote-space opened this issue Nov 19, 2021 · 0 comments · Fixed by #171
Closed

差分の詳細を算出しないモードの追加 #173

technote-space opened this issue Nov 19, 2021 · 0 comments · Fixed by #171
Assignees
Labels
Priority: Low Priority: Low Type: Breaking Change Creates incompatibility with current version

Comments

@technote-space
Copy link
Owner

technote-space commented Nov 19, 2021

Please describe your suggestion: 提案の概要

一つずつ差分の行数を取得しているため大量に差分がある場合にかかる
おそらく #172 はそれが原因
正直、差分の行数を使うことのほうが少ないと思うので、デフォルトでは行数を計算する動作を行わないようにして、パラメータで指定があったら計算するようにする

Describe the solution you'd like: 考えうる解決方法

機能的には現状問題ない
性能の問題

Describe alternatives you've considered: 考えうる代替案

他のアクションを使用
自分で git diff する
など

Additional context: 補足

@technote-space technote-space self-assigned this Nov 19, 2021
@technote-space technote-space added Type: Breaking Change Creates incompatibility with current version Priority: Low Priority: Low labels Nov 19, 2021
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Jan 4, 2022
technote-space added a commit that referenced this issue Jan 5, 2022
BREAKING CHANGE: changed default behavior
technote-space added a commit that referenced this issue Jan 5, 2022
feat: add flag whether to get file diff (#173)
@github-actions github-actions bot mentioned this issue Jan 5, 2022
1 task
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Low Priority: Low Type: Breaking Change Creates incompatibility with current version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant