-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: improve style for mobile view #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have a problem with adding the unminified |
Mmmm.. what about |
|
@iranl check now? 🙏🏻 |
iranl
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the website more mobile-friendly - note the main menu needs another change (not to do on this PR).
Changes
.adapt
class to<form>
, this way we skip the page Access Level Configuration, which currently has an acceptable view layout for phone.display: block
, underneath the previous cell.ConfirmationHtml
function to useHeaderHtml
function, this way, when the user updates configuration, it will usestyle
CSS, and the page won't render as a blank website.NOTE: While I separated the content into a new file
style.css
, bear in mind this is not integrated into build process.I am using https://www.freeformatter.com/css-minifier.html to minify the CSS file and copying the content back again to the header file as
const
. You can request to delete the newstyle.css
file if you wish.