-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make file expectations always check all expected files at once #1076
Conversation
…t panic after first different file
Quick thought: Would it be possible to make CI prioritize, say, |
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
+ Coverage 45.96% 46.21% +0.24%
==========================================
Files 171 171
Lines 64180 64843 +663
==========================================
+ Hits 29499 29964 +465
- Misses 34681 34879 +198
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@CraftSpider The main tests should all run in parallel, so in principle there shouldn't be a wait ... but maybe if we hit the limit for simultaneous jobs, and the dispatcher files them in lexical order, there would be an issue? You could try editing |
Sounds like it's worth a try - I consistently see only some running, I kind of figured it was some max concurrency limit. |
Did the reordering of the Azure Pipelines file seem to help? |
Yep, it appears putty clippy and rustfmt at the top gave them more 'priority' in the queue - they tend to now be the first to finish, which is nice. |
Want to note, since it isn't in any of the comments on this PR: This removed the cross-mips build, due to the recent Rust decision to downgrade these platforms to T3, and consequent removal of host-tools builds for them causing CI to fail. If they are ever re-upgraded to T2 (could happen if someone steps up as a maintainer) the build can be easily re-added. |
I did notice that, thanks. This means that we lose our big-endian test build, which is why I added MIPS in the first place. That's too bad but it doesn't seem to exactly be a major use case these days, and hopefully the existing code won't bit-rot on us. |
This keeps bothering me while debugging bibtex failures, and just flipping the file order there would work, but it would be a band-aid, not a real solution. So here's a real solution - make all expectations test once, and panic once at the end.
(Also removed
genio
from bibtex tests, as it just confuses the output and all the useful logs go to both stdout and the file, IME)