Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unclosed multiline comment" using /* ... /**/ #67

Closed
anakonda3000 opened this issue Sep 27, 2017 · 3 comments · Fixed by #118
Closed

"Unclosed multiline comment" using /* ... /**/ #67

anakonda3000 opened this issue Sep 27, 2017 · 3 comments · Fixed by #118

Comments

@anakonda3000
Copy link

Hi

The minifier thows an error when I use following multiline comment:

var d = 1; /* test comment /**/ var d = 2;

This is a valid comment but not correctly handled by the shrinker.

BR

@Pangamma
Copy link

Pangamma commented Feb 3, 2018

I'm also noticing this as well.

/* SOME STUFF HERE
* WILL
* FAIL */

@benjamw
Copy link

benjamw commented Feb 8, 2019

This is due to $js = str_replace('/**/', '', $js); in the initialize function.

Not even sure why that replacement is in there. It will get handled by the comment parser.

tedivm added a commit that referenced this issue Mar 4, 2023
@tedivm
Copy link
Member

tedivm commented Mar 4, 2023

Thanks for the issue! I've added the example into the test suite, and it appears that it was resolved in the refactor that removed the str_replace code.

@tedivm tedivm closed this as completed Mar 4, 2023
tedivm added a commit that referenced this issue Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants