Changed checkFileSystemPermissions arguments so PHP 8 won't throw Deprecated info #404
Conversation
|
Hi @tedivm. Would you be able to publish a new tag ( Thank you in advance. 😉 |
|
@konradoboza - sometime this week. If you check out the main branch I did a ton of work today migrating tests over to Github actions and merged some other PRs in as well, with the goal of speeding up development going forward. I'll be honest travis-ci shutting down open source projects happened at the worst time for me, as I was switching jobs and moving to Chicago. I didn't want to release until the tests were passing CI at a minimum, which is now happening in main. |
It's been over a week now 😉 |
|
Yeah my cat died last weekend, kind of ruined my plans. Then I handed in notice at my job. |
|
New release is up! 0.17.0, which will likely be the last line before v1. |
| @@ -209,7 +209,7 @@ public static function normalizeKeys($keys, $hash = 'md5') | |||
| * @throws Exception\RuntimeException | |||
| * @throws Exception\InvalidArgumentException | |||
| */ | |||
| public static function checkFileSystemPermissions($path = null, $permissions) | |||
| public static function checkFileSystemPermissions($path, string $permissions) | |||
There was a problem hiding this comment.
Shouldn't $permissions be an integer?
If we have set opcache.enable = 1 with PHP 8, then information is displayed: "Deprecated: Optional parameter $path declared before required parameter $permissions is implicitly treated as a required parameter in /var/www/html/vendor/tedivm/stash/src/Stash/Utilities.php on line 212", it causes a problem with being able to set via ini_set function session.path:
Warning: ini_set(): Session ini settings cannot be changed after headers have already been sent
The proposed change will not affect the operation of the application and will remove information about Deprecated, which will prevent the appearance of Warning