Add additional config options: #580
Conversation
dateFormat, enableAnsiNull, enableAnsiPadding, enableAnsiWarnings, enableConcatNullYeldsNull, enableCursorCloseOnCommit, enableImplicitTransactions, enableNumericRoundabort, enableQuotedIdentifier, language. Relates to tediousjs#507 tediousjs#506 tediousjs#501 tediousjs#503 This is a cleaned up merged version of tediousjs#508.
|
This is a cleaned up version of #508. Had to do a manual merge because of the extensive changes that happened in the mean time. |
CURSOR_CLOSE_ON_COMMIT. These options are not part of session properties and hence need a different approach to testing.
enableImplicitTransactions.
…tion an testBadBooleanConfigOption. This gets rid of a ton of repetitive code.
|
@arthurschreiber @rossipedia Can I get a code review? Can't commit without an approval anymore :-) @ariskemper Please note that I attributed the original commit on this PR to you. Thanks for putting the original together. If you're able to make a pass that'll be great. |
|
@arthurschreiber @rossipedia @tvrprasad will this be merged in next release? |
|
@ariskemper I'm waiting on a review to commit this. |
|
@tvrprasad I made quick review and it looks ok to me, however it needs rebase with master. |
|
@v-suhame This is another PR that's been lying around waiting for approval. I'll appreciate if you're able to take it through and merge. This should be a relatively straightforward merge. And there are folks very much interested in these new options. |
|
Done 👍 |
|
Awesome :-) |
dateFormat, enableAnsiNull, enableAnsiPadding, enableAnsiWarnings,
enableConcatNullYeldsNull, enableCursorCloseOnCommit,
enableImplicitTransactions, enableNumericRoundabort, enableQuotedIdentifier,
language.
Relates to #507 #506 #501 #503
This is a cleaned up merged version of #508.