-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ActiveDirectoryPassword and sqlpassword authentication support #707
Merged
Merged
Changes from 1 commit
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
6e2d073
feat: aad authentication support
8c971f8
chore: add linebreak
b4441fd
chore: lint fix
6cfa3cd
chore: fix else block indentations
4d91c4f
refactor: use error instead of assert
511338d
chore: merge branch master
1cad62c
refactor: remove authentication from connection class configs
9f691c9
test: add feature ext parser test
de5e3b8
refactor: export login7paylod by name
8a9b876
refactor: pass parsed data to callback
dd2bbc9
fix: add featureextack event to catch errors
4dd2b1f
test: add error cases for invalid aad auth
fc24867
test: add unit test for fedauth info parser
12a902f
chore: removed required flow
fe0122b
chore: rename Pos to offset
ce3eceb
test: writeuint32atoffset unittest
ce13bdc
chore: rename writeuin32leatpos to offset
c233c74
chore: edit the error messages
2cd3240
Merge branch 'master' into federated-auth
e36869a
ci: enable azure active directory testing in ci
036433d
ci: update travis configuration
arthurschreiber f6772bf
ci: fix a typo in the travis configuration
arthurschreiber 1ad29ed
ci: tweak travis configuration a bit
arthurschreiber eba1623
ci: fix variable substitution
arthurschreiber 49558e2
ci: don't run azure tests for pull requests
arthurschreiber eca2499
ci: update travis config to use the correct variables
arthurschreiber 62a24fd
refactor: remove async times
ee2714b
fix: parse multiple featues
3e07782
refactor: test multiple features
8df7254
Merge branch master
0702b77
fix: store acks in map
eb71906
fix: check fedauth ack before transition to login7
800e9a4
chore: rename featureextack and preloginrequired
d63c358
fix: check for feature ext ack before login
244c05a
chore: fix linter issues
c7663fb
fix: connecting with sqlpassword and non ad user
80a9313
fix: undefined property error
6b4a86d
chore: Merge branch master
cc71fe9
Merge branch 'master' of github.com:tediousjs/tedious into federated-…
arthurschreiber aa4437e
Merge branch 'master' of github.com:pekim/tedious into federated-auth
arthurschreiber b2645cc
Merge branch 'master' of github.com:pekim/tedious into federated-auth
arthurschreiber c2168cd
test: update `Login7Payload` test cases
arthurschreiber ea96250
fix: fix failure using regular authentication
arthurschreiber 1257d5b
ci: remove `SqlPassword` authentication type from Travis config
arthurschreiber d42004e
refactor: start working on a new `authentication` config option
arthurschreiber ca3aba5
Merge branch 'federated-auth' into federated-auth
78e9460
chore: merge branch master
0a28dd1
fix: config validations
ef3860d
chore: Merge branch 'master'
9759b65
fix: travis config
c183a1b
chore: fix linter issue
3f62dbd
fix: flow type
2da13de
chore: add missing fedauthinfo flag
7e9f341
fix: add removed fedauthreq flag
59e5386
chore: fix merge conflicts
d8c8f97
fix: buffer allocation, error handling
b212b29
chore: linter
8029edc
Merge branch 'master' of github.com:tediousjs/tedious into federated-…
arthurschreiber 851630e
ci: update Travis config for Azure AD Auth
arthurschreiber 16c8ae6
fix: authentication type check
arthurschreiber 60e11a7
fix: check for authentication type
arthurschreiber 5ec11aa
Merge branch 'master' of github.com:pekim/tedious into federated-auth
arthurschreiber 34321da
chore: update `package-lock.json`
arthurschreiber 6066810
refactor: remove unused property
arthurschreiber fc923e4
refactor: remove unused code
arthurschreiber 4515d4c
refactor: remove `fedAuthLibrary` property
arthurschreiber 2325bdb
refactor: small code cleanups
arthurschreiber 79ab731
refactor: always signal federated authentication support
arthurschreiber db5dd73
refactor: move logic into the state
arthurschreiber 078f384
refactor: remove `featureExtAckPending` property
arthurschreiber 9b453c1
refactor: remove `requiredPreLoginResponse` property
arthurschreiber df4570e
refactor: get rid of `fedAuthInfo` property
arthurschreiber 64324d5
refactor: simplify prelogin payload processing
arthurschreiber d658927
test: skip connection retry tests when authenticating via Azure AD
arthurschreiber e76668b
test: fix bad credential tests to support Azure AD authentication
arthurschreiber 42dadb1
refactor: simplify offset tracking when writing to a buffer
arthurschreiber 263cde1
fix: use `Buffer.alloc`
arthurschreiber 3b65260
refactor: remove `return` statements
arthurschreiber c77cd55
refactor: remove unused code
arthurschreiber 14d3d22
style: remove empty line
arthurschreiber 7f602ab
test: fix checking for Azure AD authentication
arthurschreiber d393e7d
test: update prelogin payload tests
arthurschreiber 60b64dd
test: drop tests for dropped function
arthurschreiber 45921fc
refactor: simplify the FEDAUTHINFO token parser code
arthurschreiber f242402
fix: do not use the global ADAL authentication cache
arthurschreiber 75e8ff4
refactor: simplify the feature ext ack parser code
arthurschreiber 532b969
test: handle missing `CREATE XML SCHEMA COLLECTION` permissions
arthurschreiber 544f2e1
test: assert connection was established correctly
arthurschreiber 9c9ffa5
test: update feature ext parser tests
arthurschreiber cd388dc
test: update login7 payload tests
arthurschreiber fffa06a
test: skip TVP test cases when missing permissions
arthurschreiber a10055f
fix: use the global ADAL cache
arthurschreiber e7b1bb5
test: skip TVP tests on older TDS versions
arthurschreiber d39dfc1
test: fix skipping of tests
arthurschreiber 2acfa02
test: use temporary procedures
arthurschreiber 231962e
test: use temporary procedure
arthurschreiber 2837053
test: handle setup failures more gracefully
arthurschreiber 19be9f6
test: increase timeouts
arthurschreiber 4face04
fix: rename `azure-active-directory` to `active-directory-password`
arthurschreiber e3a5a89
Merge branch 'master' of github.com:tediousjs/tedious into federated-…
arthurschreiber 8a597f9
text: update tests for authentication type rename
arthurschreiber 01a36f8
fix: rename config option back
arthurschreiber 572e97b
Merge branch 'master' into federated-auth
arthurschreiber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep adal library check and FEDAUTH_OPTIONS and ADAL LIBRARY as we'll expand the feature to other auth types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well, I'd rather have this as separate authentication types, instead of mixing this all together into one type with a large set of options.