Add typing for tmt/steps/report/__init__.py #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhavlin
force-pushed
the
typing-steps-init
branch
from
d0a85e7 to
58feaa7
Compare
44 tasks
janhavlin
force-pushed
the
typing-steps-init
branch
from
58feaa7 to
d19fc9e
Compare
janhavlin
added
code | type annotations
janhavlin
force-pushed
the
typing-steps-init
branch
from
d19fc9e to
d6f4ccc
Compare
janhavlin
changed the title
This was referenced Jul 4, 2022
lukaszachy
force-pushed
the
typing-steps-init
branch
from
d6f4ccc to
56a5a12
Compare
psss
requested changes
Jul 8, 2022
happz
reviewed
Jul 8, 2022
janhavlin
force-pushed
the
typing-steps-init
branch
from
56a5a12 to
5afc226
Compare
janhavlin
force-pushed
the
typing-steps-init
branch
from
5afc226 to
8474d7d
Compare
psss
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
After changes in ffaa8ec and 809aed5 looks good and ready for merge. @janhavlin, @thrix, could you have a quick look and confirm those changes are ok?
LGTM. Thanks for the updates. |
Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.