Add the `link` command and linking new tests to jira #2922

tkoscieln · 2024-05-09T11:18:49Z

Pull Request Checklist

LecrisUT · 2024-05-09T14:41:14Z

Could use an example of how this works. Probably this needs to be abstracted a bit for more arbitrary issue providers. Are there no plans yet to strip out some of the tmt plugins in order to minimize the dependencies and tests?

tkoscieln · 2024-05-09T14:50:40Z

Could use an example of how this works. Probably this needs to be abstracted a bit for more arbitrary issue providers. Are there no plans yet to strip out some of the tmt plugins in order to minimize the dependencies and tests?

This is currently WIP, hence why it is in Draft. Will provide more information once the initial refactor suggested by @psss in a discussion will be implemented.

tkoscieln · 2024-05-10T11:58:37Z

Added a section to documentation which should explain what this change aims to introduce. Related Jira issue TT-262.

LecrisUT · 2024-05-10T12:41:07Z

Thanks for the clarification I kinda understand the setup, and I am more confused about it at the same time. The main idea is to add in the Issue links a link to the tmt test/plan/story that would fix a specific issue. The confusing part is the usage of the service field. This seems to imply that the tmt metadata is served somehow probably as teemtee/web? That part should be advertised a bit more if that is the only linkage that would be supported. What about general audience?

Another question I have is what happens with the links when a test/structure gets refactored. Could the tests be traced back through the git tree to see how it evolves and re-links?

tmt/base.py

tmt/cli.py

tmt/utils.py

docs/guide.rst

tmt/utils.py

tmt/base.py

pyproject.toml

psss

Thanks a lot for working on this! Overall looks very good. Added some comments and suggestions.

docs/guide.rst

tmt/cli.py

tmt/utils.py

psss · 2024-08-07T10:04:39Z

This is an important feature blocking proper Jira integration and traceability. Marking as a must have. Let's try hard to finish this in 1.36..

psss · 2024-08-09T09:34:32Z

@tkoscieln, could you please address the comments and add a short release note? Thanks!

docs/guide.rst

Traceback (most recent call last): File "/home/psss/.local/share/hatch/env/virtual/tmt/v_yBwOy-/dev/bin/tmt", line 5, in <module> from tmt.__main__ import run_cli File "/home/psss/git/tmt/tmt/__init__.py", line 20, in <module> from tmt.base import Clean, Plan, Run, Status, Story, Test, Tree File "/home/psss/git/tmt/tmt/base.py", line 57, in <module> import tmt.utils.jira File "/home/psss/git/tmt/tmt/utils/jira.py", line 21, in <module> tmt.log.Logger.get_bootstrap_logger()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 871, in get_bootstrap_logger cls._bootstrap_logger = Logger.create(actual_logger=actual_logger) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 686, in create return Logger( ^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 629, in apply_verbosity_options debug_level_from_global_envvar = _debug_level_from_global_envvar() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/psss/git/tmt/tmt/log.py", line 123, in _debug_level_from_global_envvar raise tmt.utils.GeneralError(f"Invalid debug level '{raw_value}', use an integer.") tmt.utils.GeneralError: Invalid debug level 'weird', use an integer.

This reverts commit 0c630b7.

Move under `Elasticity` Simplify some wording. Use the planned `tmt-web-url`.

Extra line Duplicate requires Missing docstrings Consistent option name

Introduce the `JiraInstance` class Separate code into more functions/methods. Simplify object detection in `cli.py`, handle empty case.

psss · 2024-09-30T10:01:43Z

I believe all crucial comments should be covered. I suggest to include this new functionality as a Tech Preview in 1.37 with the primary goal to gather feedback from users about the proposed implementation. Please, review, as this is the last remaining must-have pull request.

psss

After changes in 7ecd3bb should be good to go.

martinhoyer

Nice!
One last thought - should jira.py be under tmt/utils/? Doesn't feel right to me. Non-blocking of course, can be moved later if desired.

tmt/cli.py

psss · 2024-09-30T12:23:03Z

The /tests/unit/with-system-packages/extended test fails with a weird error:

stderr     = ('dnf5: error while loading shared libraries: libfmt.so.10: cannot open shared '
'object file: No such file or directory\n')

Does not seem to be related. Rerunning though.

psss · 2024-09-30T12:25:58Z

One last thought - should jira.py be under tmt/utils/? Doesn't feel right to me. Non-blocking of course, can be moved later if desired.

Ack, yeah, we can find a better place for it in the future.

psss · 2024-09-30T13:18:02Z

Failures seem to be related to dnf in the fedora-39 container. Merging.

psss changed the title ~~Add link command and linking to jira on new issues.~~ Add link command and linking to jira on new issues May 9, 2024