Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install prepare plugin using install into tmt try #3071

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add install prepare plugin using install into tmt try #3071

wants to merge 16 commits into from
+57 −3

Conversation

falconizmi
Copy link
Collaborator

@falconizmi falconizmi commented Jul 2, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • adjust plugin docstring
  • mention the version
  • include a release note

@falconizmi falconizmi changed the title Iquwarah tmt try package Add package prepare plugin using install into tmt try Jul 2, 2024
@falconizmi falconizmi added step | prepare Stuff related to the prepare step command | try tmt try command labels Jul 2, 2024
@lukaszachy
Copy link
Collaborator

Isn't it more natural to call that option install? As in tmt try --install zsh fedora@container....

@falconizmi falconizmi assigned falconizmi and unassigned falconizmi Jul 10, 2024
@falconizmi falconizmi changed the title Add package prepare plugin using install into tmt try Add install prepare plugin using install into tmt try Jul 11, 2024
@falconizmi falconizmi added the ci | full test Pull request is ready for the full test execution label Jul 11, 2024
@falconizmi falconizmi force-pushed the iquwarah-tmt-try-epel branch 2 times, most recently from c2806be to 9ea8e3b Compare July 29, 2024 14:37
@happz happz added this to the 1.36 milestone Jul 31, 2024
@happz happz modified the milestones: 1.36, 1.37 Sep 3, 2024
happz
happz requested changes Sep 16, 2024
View reviewed changes
docs/releases.rst Outdated Show resolved Hide resolved
stories/cli/try.fmf Outdated Show resolved Hide resolved
@falconizmi falconizmi force-pushed the iquwarah-tmt-try-epel branch 3 times, most recently from 66a661a to 241dda6 Compare September 16, 2024 14:11
@falconizmi
Copy link
Collaborator Author

/packit build

happz
happz reviewed Sep 24, 2024
View reviewed changes
docs/releases.rst Outdated Show resolved Hide resolved
Base automatically changed from iquwarah-tmt-try-epel to main September 24, 2024 13:43
psss
psss approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! Looks good. In 1b7d1f5 I've just adjusted the option description (we support non-local and non-rpm packages as well) and the release note a bit.

tmt/cli.py Outdated Show resolved Hide resolved
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 30, 2024
Ismail Ibrahim Quwarah and others added 16 commits October 1, 2024 09:25
@psss
Add epel prepare plugin using feature
c0fbfb5 
fix handle options in tmt try

Drop unnecessary prepare- from phase name
@psss
Add epel release note in tmt try
1912f9d 
fix `epel` release note in tmt try

Add mention of prepare/feature plugin in tmt try release notes

Adjust text length to match the header

Fix links to plugins (#3104)

Add missing full stop
@psss
Move release note to 1.37
67d1359
@psss
Simplify the implementation a bit
3ab4df3 
The extra action for handling options should not be needed.
Plus it breaks use cases like `tmt try --epel` with tests.
Included a few minor style adjustments.
@psss
Add package prepare plugin using install in tmt try
22b0e7b 
Drop unnecessary prepare- from phase name
@psss
Add package coverage test in tmt try
6bd7f9d
@psss
Add package documentation in tmt try
eec0751
@psss
Add package release note in tmt try
0956c5e
@psss
Change option name package to install in tmt try
d5fc39b
@psss
Add mention of prepare/install plugin in tmt try release notes and do…
9520fae 
…cumentation
@psss
Adjust text length to match the header
399b992
@psss
Fix links to plugins (#3104)
ba0c8a7
@psss
Fix versionadded to current one
518158c
@psss
Move tmt try install release note to 1.37
6907484
@falconizmi @happz @psss
Add new line before release note
7a1771f 
Co-authored-by: Miloš Prchlík <mprchlik@redhat.com>
@psss
Adjust the release note and option description
e540617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@happz happz happz approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution command | try tmt try command status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | prepare Stuff related to the prepare step
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
4 participants
@falconizmi @lukaszachy @happz @psss