Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop no longer needed is_selinux_supported() #3191

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Drop no longer needed is_selinux_supported() #3191

merged 1 commit into from
Sep 17, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 5, 2024

Guest has_selinux fact should be used instead, now when we have guest facts.

Pull Request Checklist

  • implement the feature

@happz happz added step | provision Stuff related to the provision step code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 5, 2024
@happz happz added this to the 1.37 milestone Sep 5, 2024
thrix
thrix approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@psss psss changed the title Drop no longer needed is_selinux_supported() Drop no longer needed is_selinux_supported() Sep 17, 2024
@psss psss added the ci | full test Pull request is ready for the full test execution label Sep 17, 2024
@happz @psss
Drop no longer needed is_selinux_supported()
fc1891a 
Guest `has_selinux` fact should be used instead, now when we have guest
facts.
@psss psss force-pushed the drop-special-selinux-function branch from 711ad59 to fc1891a Compare September 17, 2024 11:18
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 17, 2024
@happz happz merged commit bf8da4a into main Sep 17, 2024
22 checks passed
@happz happz deleted the drop-special-selinux-function branch September 17, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
6 participants
@happz @thrix @KwisatzHaderach @psss @martinhoyer @therazix