Support Fedora Image Mode #3229
Draft
+71
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrix
added a commit
to testing-farm/gluetool-modules
that referenced
this pull request
Sep 20, 2024
With tmt from this MR: teemtee/tmt#3229 Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
thrix
force-pushed
the
image-mode-fedora
branch
from
8c1c5db
to
b447a6a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
happz
reviewed
Sep 30, 2024
tmt/steps/execute/__init__.py
Outdated
| @@ -58,6 +59,9 @@ | |||
| # Scripts source directory | |||
| SCRIPTS_SRC_DIR = tmt.utils.resource_files('steps/execute/scripts') | |||
|
|
|||
| # Scripts destination directory, hardcoded in the tmt.sh script | |||
| SCRIPTS_DEST_DIR = "/var/tmp/tmt/bin" | |||
There was a problem hiding this comment.
It's a path, it shall be a Path instance.
There was a problem hiding this comment.
And I'd add a way to override this path right from the beginning, check out effective_pidfile_root(), but that would conflict with easy hard-coding the path into tmt.sh... Still, hard-coded paths turned out to not be generally usable, sooner or later, might be a good investment to get this one configurable while we're not [ushed by a looming regression...
There was a problem hiding this comment.
Makes sense. Let's make it configurable.
happz
reviewed
Sep 30, 2024
happz
reviewed
Sep 30, 2024
happz
reviewed
Sep 30, 2024
thrix
force-pushed
the
image-mode-fedora
branch
3 times, most recently
from
e48ac2b
to
c8115ad
Compare
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist