Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include error and traceback in log file #3247

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Include error and traceback in log file #3247

merged 2 commits into from
Oct 18, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 30, 2024

Always in full detail, traceback is added to log files tmt opened during its run.

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@happz happz added this to the 1.38 milestone Sep 30, 2024
@happz happz marked this pull request as ready for review October 7, 2024 13:28
@happz happz added the code | logging Changes related to debug logging label Oct 7, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 16, 2024
@happz
Copy link
Collaborator Author

happz commented Oct 17, 2024

@lukaszachy what do you think about this PR?

@lukaszachy
Copy link
Collaborator

@lukaszachy what do you think about this PR?

Finally! All one would need to debug issues will be in the log.txt.

Always in full detail, traceback is added to log files tmt opened during
its run.
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 18, 2024
@happz
Copy link
Collaborator Author

happz commented Oct 18, 2024

Unrelated failure, merging.

@happz happz merged commit 39ee214 into main Oct 18, 2024
21 of 22 checks passed
@happz happz deleted the traceback-into-logfile branch October 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | logging Changes related to debug logging status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants