Avoid using raw step data when injecting phases #3248
Draft
+93
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix handle options in tmt try Drop unnecessary prepare- from phase name
fix `epel` release note in tmt try Add mention of prepare/feature plugin in tmt try release notes Adjust text length to match the header Fix links to plugins (#3104) Add missing full stop
The extra action for handling options should not be needed. Plus it breaks use cases like `tmt try --epel` with tests. Included a few minor style adjustments.
Drop unnecessary prepare- from phase name
Co-authored-by: Miloš Prchlík <mprchlik@redhat.com>
Actual step data containers come with type annotations and better checking.
happz
added
the
code | no functional change
psss
force-pushed
the
iquwarah-tmt-try-package
branch
2 times, most recently
from
1b7d1f5
to
e540617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual step data containers come with type annotations and better checking.
Pull Request Checklist