Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate "effective config path" code in a function #3250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Isolate "effective config path" code in a function #3250

wants to merge 1 commit into from

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 30, 2024

This now matches how other configurable paths are handled, workdir root, pid root.

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@happz
Isolate "effective config path" code in a function
ce9f580 
This now matches how other configurable paths are handled, workdir root,
pid root.
@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 30, 2024
@happz happz added this to the 1.38 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix.
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.
1 participant
@happz