Add tests for special characters in beakerlib phase names #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberm
added
area | results
seberm
force-pushed
the
feature/test-phases-special-names
branch
2 times, most recently
from
e343054
to
d5eff51
Compare
seberm
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
seberm
force-pushed
the
feature/test-phases-special-names
branch
2 times, most recently
from
3ecb421
to
21d8a49
Compare
|
/packit test |
seberm
commented
Nov 8, 2024
| /sbin/ldconfig \ | ||
| /usr/sbin/ldconfig \ | ||
|
|
||
| # Cover other special characters in the phase name |
|
/packit test |
seberm
force-pushed
the
feature/test-phases-special-names
branch
from
17940c9
to
0403036
Compare
|
Hello @psss, this one should be ready for review. I've modified the tests to always check the values of the concrete subresult extracted using the The problems in the CI (in |
|
/packit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR until the beakerlib changes are released.
This PR adds tests for special characters in beakerlib phase names. It checks the special characters are correctly handled by beakerlib & tmt and propagated into the internal structures (esp.
results.yaml,tmt-report-results.yaml).Related to:
Pull Request Checklist