Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
feature_gates
andruntime_config
are still broken.The feature_gates map also had the same problem with the expected type as the runtime_config had. I also had to initialize the
RuntimeConfig
andFeatureGates
maps of the kind resource, as otherwise go would complain about an assignment to an entry in a nil map.The test cases were also wrong, as you changed the types of those two options to maps.
Feel free to edit/ask for any changes 😊